1326175 - Stop preserving empty passwords in URLs

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Anne (:annevk)]

Input:

  https://test:@test/

Expected output:

  https://test@test/

Actual output:

  https://test:@test/

Input

  https://:@test/

Expected output:

  https://test/

Actual output:

  Failure

Tests:

  https://github.com/w3c/web-platform-tests/issues/4405

Standard:

  https://github.com/whatwg/url/pull/186

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1326175 - Stop preserving empty passwords in URLs

Review commit: https://reviewboard.mozilla.org/r/123850/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/123850/

Comment 2

[Anne (:annevk)]

Why add more mochitests? Are the web-platform-tests not sufficient? If so, why not add more tests there?

Comment 3

[Valentin Gosu [:valentin] (he/him)]

(In reply to Anne (:annevk) from comment #2)
> Why add more mochitests? Are the web-platform-tests not sufficient? If so,
> why not add more tests there?

I added another xpcshell test because that tests the internal nsStandardURL implementation, while WPT tests the URL implementation. This is needed to test other code paths which may not be exposed to the web API such as nsIURI::SetUserPass

Comment 4

[Patrick McManus [:mcmanus]]

Comment on attachment 8851540 [details]
Bug 1326175 - Stop preserving empty passwords in URLs

https://reviewboard.mozilla.org/r/123850/#review126286

Comment 5

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8851540 [details]
Bug 1326175 - Stop preserving empty passwords in URLs

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/123850/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a00e1ca8f47
Stop preserving empty passwords in URLs r=mcmanus

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4a00e1ca8f47