1326232 - Certain tasks missing for try builds even specified via try chooser

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Earlier today I pushed the following try build:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=32d44b9ef42a

As it can be seen I requested marionette tests for all platforms, but only those for OS X were run because that's Buildbot. All TC tasks have been stripped off and were not run.

I talked with Dustin on IRC and he mentioned that he knows what it is.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

I forgot that try_option_syntax.py special-cases the (now-defunct) test kind names

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: Bug 1326232: correctly match tests with try syntax;

Review commit: https://reviewboard.mozilla.org/r/101378/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/101378/

Comment 3

[Justin Wood (:Callek)]

Comment on attachment 8822465 [details]
Bug 1326232: correctly match tests with try syntax;

https://reviewboard.mozilla.org/r/101378/#review101864

yay at hardcoded kind names. I wonder where else we did that? :-) [cough: nightly stuff]

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/158b636207cf
correctly match tests with try syntax; r=Callek

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/158b636207cf