132626 - search context menu item is awfully wordy [prefs corruption?]

Status: VERIFIED FIXED

(SeaMonkey :: Search, defect)

Description

[sairuh (rarely reading bugmail)]

around 12/20/2001, the search context menu item was short'n'sweet by only saying
"Search for <selection>". but now --at least since 12/26/2001 (sorry don't have
builds in btwn)-- the item is dreadfully long: "Search Netscape Search for
<selection>". this makes the context menu rather wide.

was this the result of fixing bug 114615, or something else?

i know that the context menu items are going to cleaned up, but i couldn't find
a more specific bug on this issue. (unless it's been resolved somewheres.) i see
this in both commercial and mozilla tip builds.

Comment 1

[sairuh (rarely reading bugmail)]

note: if the selection context menu is, however, implemented per marlon's spec,
then this bug would be taken care of. :)

Comment 2

[Samir Gehani]

> was this the result of fixing bug 114615, or something else?

This was the result of German's spec.

Who is doing the context menu revision per Marlon's spec?  

Blake,
Should you get this?

Comment 3

[sairuh (rarely reading bugmail)]

okay, i create a new profile with 2002.03.25.08 bits [comm linux] and noticed
that i no longer get the long-winded version of this item. ie, no longer see
Search Netscape Search for "<selection>". perhaps profile corruption?

removing localstore.rdf didn't help, so am gonna try moving out prefs.js...

however, there's still a bug [separate from this one], in that Search for
"selection" is *still* in the context menu, even if there's *no* selection.
might file a bug for that, but mebbe the context menu rewrite might take care of
it...?

Comment 4

[sairuh (rarely reading bugmail)]

moving out prefs.js did the trick --gonna see if there's a particular pref that
triggers this (if applicable).

Comment 5

[sairuh (rarely reading bugmail)]

hokay narrowed it down to this recipe:

* once i view the Internet Search pref panel *and* click OK (to dismiss the
window --doesn't matter if you've made a change), this bug crops up --i get the
long version of the 'Search <whichever engine> for "<selection>" ' in the
context menu.

* if i've never viewed the Internet Search pref panel *or* view that panel but
hit Cancel, i only see the short version, 'Search for "<selection>" ' in the
context menu.

Comment 6

[sairuh (rarely reading bugmail)]

filed bug 133350 for the ever-present Search item in context menus (per comment 3).

Comment 7

[Blake Ross]

-> me

Comment 8

[Blake Ross]

Fixed.   New wording is the short 'n sweet "Web Search for <text>" per the new
cm spec.

Comment 9

[sairuh (rarely reading bugmail)]

indeed! vrfy'd fixed (branch, trunk, all).