Upgrade to Hunspell 1.6.0

RESOLVED FIXED in Firefox 53

Status

()

Core
Spelling checker
RESOLVED FIXED
a year ago
11 months ago

People

(Reporter: RyanVM, Assigned: RyanVM)

Tracking

Trunk
mozilla53
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(1 attachment)

+++ This bug was initially created as a clone of Bug #1318955 +++

Changes since v1.5.4:

2016-12-22 Dimitrij Mijoski <dmjpp at hotm>:
 * Version 1.6.0
 * Changes in the library:
 *  Performance improvement in ngsuggest(), suggestions should be faster.
 *  Revert MAXWORDLEN to 100 as in 1.3.3 for performance reasons.
 *  MAXWORDLEN can be set during build time with -D defines.
 *  Fix crash when word with 102 consecutive X is spelled.

The MAXWORDLEN change is just the upstreaming of bug 1322666, which means it's one less in-tree deviation we need to carry on our end. The 102 X character crash is bug 1322655, which is currently wallpapered over by bug 1322666 (we won't check anything longer than 100 characters), but it would be nice to get the real upstream fix so we're safe should we ever want to change the maximum word length we check in Firefox. That said, I think we can just let this ride the trains vs. uplifting to older releases too.
Comment on attachment 8822501 [details] [diff] [review]
Update Hunspell to version 1.6.0

Green on Try.
Attachment #8822501 - Flags: review?(masayuki)

Comment 3

a year ago
(In reply to Ryan VanderMeulen [:RyanVM] from comment #0)
> The 102 X
> character crash is bug 1322655, which is currently wallpapered over by bug
> 1322666 (we won't check anything longer than 100 characters), but it would
> be nice to get the real upstream fix so we're safe should we ever want to
> change the maximum word length we check in Firefox.

This is properly fixed, independent of what is the value of MAXWORDLEN. You can safely close bug 1322655.
Yeah, I intend to close it out once this bug lands.
Comment on attachment 8822501 [details] [diff] [review]
Update Hunspell to version 1.6.0

Assuming that you're just updating Hunspell from the upstream.
Attachment #8822501 - Flags: review?(masayuki) → review+

Comment 6

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a0047bcc0220
Upgrade Hunspell to version 1.6.0. r=masayuki

Comment 7

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a0047bcc0220
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53

Comment 8

a year ago
Can you also bump version in extensions/spellcheck/hunspell/src/README.mozilla ?

Comment 9

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b0620e0ae29d
Update README.mozilla to reflect the correct in-tree Hunspell version. DONTBUILD

Updated

11 months ago
Blocks: 1350908
You need to log in before you can comment on or make changes to this bug.