Crash in AsyncShutdownTimeout | places-will-close-connection | PlacesUtils read-only connection closing as part of Places shutdown

NEW
Unassigned

Status

()

P3
critical
2 years ago
9 days ago

People

(Reporter: alex_mayorga, Unassigned, NeedInfo)

Tracking

({crash, top50, topcrash})

50 Branch
x86
Windows 10
crash, top50, topcrash
Points:
---

Firefox Tracking Flags

(firefox50 wontfix, firefox51 wontfix, firefox52 wontfix, firefox-esr60 affected, firefox53 wontfix, firefox56 wontfix, firefox57 wontfix, firefox58 wontfix, firefox59 wontfix, firefox60 wontfix, firefox61 wontfix, firefox62 wontfix, firefox63- wontfix, firefox64- fix-optional, firefox65- affected)

Details

(crash signature)

(Reporter)

Description

2 years ago
This bug was filed from the Socorro interface and is 
report bp-cfb6a35f-2194-4263-90fe-882912161228.
=============================================================

¡Hola!

Found about this type of crash form https://support.mozilla.org/en-US/questions/1152126

There are 246 in the past week at https://crash-stats.mozilla.com/signature/?product=Firefox&signature=AsyncShutdownTimeout%20%7C%20places-will-close-connection%20%7C%20PlacesUtils%20read-only%20connection%20closing%20as%20part%20of%20Places%20shutdown

Filing it FWIW.

¡Gracias!
(Reporter)

Comment 1

2 years ago
Crashing Thread (0)
Frame 	Module 	Signature 	Source
0 	mozglue.dll 	mozalloc_abort(char const* const) 	memory/mozalloc/mozalloc_abort.cpp:33
1 	xul.dll 	NS_DebugBreak 	xpcom/base/nsDebugImpl.cpp:436
2 	xul.dll 	nsDebugImpl::Abort(char const*, int) 	xpcom/base/nsDebugImpl.cpp:146
3 	xul.dll 	NS_InvokeByIndex 	xpcom/reflect/xptcall/md/win32/xptcinvoke_asm_x86_msvc.asm:54
4 	xul.dll 	XPCWrappedNative::CallMethod(XPCCallContext&, XPCWrappedNative::CallMode) 	js/xpconnect/src/XPCWrappedNative.cpp:1361
5 	xul.dll 	XPC_WN_CallMethod(JSContext*, unsigned int, JS::Value*) 	js/xpconnect/src/XPCWrappedNativeJSOps.cpp:1128
6 	xul.dll 	js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct) 	js/src/vm/Interpreter.cpp:453
7 	xul.dll 	InternalCall 	js/src/vm/Interpreter.cpp:498
8 		@0x1
Too late for firefox 52, mass-wontfix.
status-firefox52: affected → wontfix
Duplicate of this bug: 1402103
status-firefox56: --- → affected
status-firefox57: --- → affected
status-firefox58: --- → affected
Severity: critical → normal
Priority: -- → P3
Updating bug with additional signature as well as marking affected branches.
Crash Signature: [@ AsyncShutdownTimeout | places-will-close-connection | PlacesUtils read-only connection closing as part of Places shutdown] → [@ AsyncShutdownTimeout | places-will-close-connection | PlacesUtils read-only connection closing as part of Places shutdown] [@ AsyncShutdownTimeout | Places Connection shutdown | PlacesUtils read-only connection closing as part of Places shutdown ]
status-firefox59: --- → affected
status-firefox60: --- → affected
status-firefox61: --- → affected
This is the #3 topcrash on beta 62. It's also a very high volume crash on release 61. 
Nathan, might it be worth taking another look at this?
Flags: needinfo?(nfroyd)
Component: XPCOM → Places
Product: Core → Toolkit
I will defer to asuth or mak on this one.

I'm really curious what places is doing here.  Looking through a couple of crash reports, the Mac reports have (sort of) reasonable stacks:

https://crash-stats.mozilla.com/report/index/e47b02da-92f0-4613-852a-cb55a0180820
https://crash-stats.mozilla.com/report/index/4c85d0e2-b044-4311-b14c-6ca350180820

But I can't tell what sort of SQL is being executed that's taking so long here.
Flags: needinfo?(nfroyd) → needinfo?(bugmail)

Comment 7

3 months ago
I wonder if this is somehow related to Sync? Bug 1483976 has a similar hang and I suspect bug 1483241 will too. Sadly, I don't think we can tell from the crash whether Sync is configured.

Updated

2 months ago
status-firefox62: --- → affected
status-firefox63: --- → affected
status-firefox64: --- → affected
status-firefox-esr60: --- → affected

Comment 8

a month ago
Top 50 Crashing Signatures. 7 days ago

Top Crashers for Firefox 64.0a1

4 	2.67% 	-0.18% 	AsyncShutdownTimeout | Places Connection shutdown | PlacesUtils read-only connection closing as part of Places shutdown 	111 	100 	6 	5 	93 	0 	2017-08-06 

Top Crashers for Firefox 63.0b
	
5 	1.46% 	0.5% 	AsyncShutdownTimeout | Places Connection shutdown | PlacesUtils read-only connection closing as part of Places shutdown	471 	440 	25 	6 	415 	0 	2017-08-06	

Top Crashers for Firefox 62.0.3

3 	2.58% 	-0.34% 	AsyncShutdownTimeout | Places Connection shutdown | PlacesUtils read-only connection closing as part of Places shutdown	3682 	3497 	123 	62 	2952 	0 	2017-08-06 

Top Crashers for Firefox 61.0.2

12 	1.08% 	0.22% 	AsyncShutdownTimeout | Places Connection shutdown | PlacesUtils read-only connection closing as part of Places shutdown	40 	33 	7 	0 	39 	0 	2017-08-06

Top Crashers for Firefox 60.0.2

12 	0.92% 	-0.49% 	AsyncShutdownTimeout | Places Connection shutdown | PlacesUtils read-only connection closing as part of Places shutdown	12 	12 	0 	0 	12 	0 	2017-08-06
	
Top Crashers for Firefox 60.2.2esr	
	
20 	0.47% 	0.01% 	AsyncShutdownTimeout | Places Connection shutdown | PlacesUtils read-only connection closing as part of Places shutdown	110 	105 	4 	1 	82 	0 	2017-08-06
Keywords: top50, topcrash
Severity: normal → critical
status-firefox50: affected → wontfix
status-firefox51: affected → wontfix
status-firefox53: affected → wontfix
status-firefox56: affected → wontfix
status-firefox57: affected → wontfix
status-firefox58: affected → wontfix
status-firefox59: affected → wontfix
status-firefox60: affected → wontfix
status-firefox61: affected → wontfix
We should still keep an eye on this for 63. It was very high volume in 62 release.
status-firefox62: affected → wontfix
status-firefox65: --- → affected
tracking-firefox63: --- → ?
tracking-firefox64: --- → ?
tracking-firefox65: --- → ?

Updated

19 days ago
tracking-firefox63: ? → +
I'll happily take a patch for this if one materializes, but I don't see much value in tracking this either.
status-firefox63: affected → wontfix
status-firefox64: affected → fix-optional
tracking-firefox63: + → -
tracking-firefox64: ? → -
tracking-firefox65: ? → -
You need to log in before you can comment on or make changes to this bug.