1326993 - Findbar next/previous buttons look very bad on dark developer edition theme

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect, P3)

Description

[arni2033]

>>>   My Info:   Win7_64, Nightly 53, 32bit, ID 20161119030204 (2016-11-19)
STR_1:
0. Open customize mode, enable developer edition theme. Open devtools, set dark theme, close devtools.
1. Open url   data:,asdf
2. Open findbar, type "zxcv" in findbar

AR:  Next/previous buttons are completely gray, up/down arrows aren't visible
ER:  Up and down arrows should be noticeable in findbar buttons

This is regression from bug 935521. Regression range:
> https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0cb0af1888e39f777862c2c24d84832b6622d40f&tochange=89101092aea13babe5a9a9e4750b89758425f1e2

Comment 1

[Jeff Griffiths (:canuckistani) (:⚡︎)]

Attachment: Nightly.png

Works for me, see screenshot

Comment 2

[Jeff Griffiths (:canuckistani) (:⚡︎)]

Re-opened, apparently this happens on Win7

Comment 3

[Tim Nguyen :ntim]

Is there someone who can test this on Windows 7 ? Bug 1418605 might have fixed this.

Comment 4

[Jeff Griffiths (:canuckistani) (:⚡︎)]

I have no idea, redirecting to Harald. Probably needs a QA flag.

Comment 5

[Patrick Brosset <:pbro>]

Without a screenshot of the issue, it's kind of hard to know whether this was fixed.
I tested on Windows 10 with DevEdition (60), and couldn't see any problem there. I'll post a screenshot of that.
I also tested on Windows 7 with Beta (60), and couldn't see any problem there either.

Note that the STRs have changed since the bug was filed, since the dark them is now decoupled from the DevTools dark theme:

0. Open customize mode, choose dark theme.
1. Open url   data:,asdf
2. Open findbar, type "zxcv" in findbar

Comment 6

[Patrick Brosset <:pbro>]

Attachment: windows7-FF60.png

Here's a screenshot on Windows 7.

Comment 7

[Tim Nguyen :ntim]

Thanks Patrick! The screenshot looks correct to me, so I'm going to close this.