Open Bug 1327037 Opened 8 years ago Updated 1 month ago

Autocomplete suggestions of numeric selectors replace typed text

Categories

(DevTools :: Inspector, defect, P3)

Product:
DevTools
Component:
Inspector
Version:
45 Branch
Type:
defect

Tracking

(firefox50 wontfix, firefox51 wontfix, firefox52 fix-optional, firefox53 wontfix, firefox54 fix-optional)

Tracking Flags:
Tracking Status
firefox50 --- wontfix
firefox51 --- wontfix
firefox52 --- fix-optional
firefox53 --- wontfix
firefox54 --- fix-optional

People

(Reporter: arni2033, Unassigned)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

>>> My Info: Win7_64, Nightly 49, 32bit, ID 20160526082509 STR_1: 1. Open url data:text/html,<body id="100"><div id="10"> 2. Open inspector 3. In search field in inspector paste "#\31 0" 4. Press Enter AR: Selector in search field is replaced to "div" ER: Selector shoudln't be changed to another, irrelevant selector
No longer blocks: 1277113
The issue is reproducible on the latest Firefox release (50.1.0) and on the latest Nightly (53.0a1). Oh noes, no (more) inbound revisions :( Last good revision: a33592050e2465ea62f9d62c42623c9c88b9808f First bad revision: 9afab6308cd97d470c6514ccb0e348103e034e4d Pushlog: https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=a33592050e2465ea62f9d62c42623c9c88b9808f&tochange=9afab6308cd97d470c6514ccb0e348103e034e4d Looks like the following bug has the changes which introduced the regression: https://bugzilla.mozilla.org/show_bug.cgi?id=1265718 Since Eddy's is disabled, Ryan could you take a look at this?
Blocks: 1265718
status-firefox50: --- → affected
status-firefox51: --- → affected
status-firefox52: --- → affected
status-firefox53: --- → affected
Component: Untriaged → Developer Tools: Animation Inspector
Flags: needinfo?(jryans)
Keywords: regressionwindow-wanted
Version: Trunk → 49 Branch
Inspector bug triage (filter on CLIMBING SHOES).
Severity: normal → enhancement
Priority: -- → P3
(In reply to Ciprian Muresan [:cmuresan] from comment #1) > Since Eddy's is disabled, Ryan could you take a look at this? Since Eddy's account is disabled ... Missed a word there.
This bug is also present in Firefox 48, which is before bug 1265718 landed, so that doesn't seem like right regression window. My guess is it's not a regression at all, but I don't have evidence of that yet. Let's try another regression window search.
No longer blocks: 1265718
Component: Developer Tools: Animation Inspector → Developer Tools: Inspector
Flags: needinfo?(jryans)
Keywords: regression → regressionwindow-wanted
I re-did the regression window search and got the following pushlog: Last good revision: cc473fe5dc512c450634506f68cbacfb40a06a23 (2015-11-10) First bad revision: 3cc3b1968524248450c465c4ea2ee5596ffa65f2 (2015-11-12) Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=cc473fe5dc512c450634506f68cbacfb40a06a23&tochange=3cc3b1968524248450c465c4ea2ee5596ffa65f2 Bug 835896 stands out a bit. Ryan, could you please check the pushlog?
Flags: needinfo?(jryans)
Keywords: regressionwindow-wanted → regression
(In reply to Ciprian Muresan [:cmuresan] from comment #5) > I re-did the regression window search and got the following pushlog: > > Last good revision: cc473fe5dc512c450634506f68cbacfb40a06a23 (2015-11-10) > First bad revision: 3cc3b1968524248450c465c4ea2ee5596ffa65f2 (2015-11-12) > Pushlog: > https://hg.mozilla.org/mozilla-central/ > pushloghtml?fromchange=cc473fe5dc512c450634506f68cbacfb40a06a23&tochange=3cc3 > b1968524248450c465c4ea2ee5596ffa65f2 > > Bug 835896 stands out a bit. > > Ryan, could you please check the pushlog? Yes, that seems like a believable culprit.
Blocks: 835896
Flags: needinfo?(jryans)
Version: 49 Branch → 45 Branch
Additional STRs from Bug 1327685 STR_1: 1. Open url data:text/html,<body id="100"><div id="10"> 2. Open inspector 3. In search field in inspector type "#", then type "1", then "0", then "0" AR: In Step 3 autocomplete suggestions change like shown below: ["#\31 00", "#\31 0"] -> ["#131 00", "#131 0"] -> ["#101 00", "#101 0"] -> ["#100 00"]. ¯ ¯ ¯¯ ¯¯ ¯¯¯ ¯¯¯ ¯¯¯¯ Underscores represent what part of suggestion is highlighted as "typed". Suggestions do this actually Value "#100 00" is neither what I typed, nor what I get if I press Tab key (I get "#\31 00") ER: Either X or Y X) Autocomplete suggestions should only show human values, just like normal words. They should be: ["#100", "#10"] -> ["#100", "#10"] -> ["#100", "#10"] -> ["#100"] ¯ ¯ ¯¯ ¯¯ ¯¯¯ ¯¯¯ ¯¯¯¯ Y) Autocomplete suggestions should display real values. They should be: ["#\31 00", "#\31 0"] -> ["#\31 00", "#\31 0"] -> ["#\31 00", "#\31 0"] -> ["#\31 00"]
Too late for a fix for 53, as we are in the last week of the 53 beta cycle.
status-firefox53: affected → wontfix
Since this has been triaged by the devtools team as a backlog bug, marking it fix-optional for 54.
status-firefox54: affected → fix-optional
status-firefox55: --- → fix-optional
Product: Firefox → DevTools
No longer blocks: 835896
Type: enhancement → defect
status-firefox55: fix-optional → ---
Regressed by: 835896
Has Regression Range: --- → yes
Severity: normal → S3

I don't think this was mentioned here, the suggestions we get are passed through CSS.escape , so we can then use them directly in querySelectorAll later

https://searchfox.org/mozilla-release/rev/cd38106203c7d9f44b75a5a112cf0488c8c8a173/devtools/server/actors/inspector/walker.js#1229,1245

result.push(["." + CSS.escape(className), count, selectorState]);
...
result.push(["#" + CSS.escape(id), count, selectorState]);
You need to log in before you can comment on or make changes to this bug.