132720 - Return and Enter keys do not correctly confirm OK/Cancel dialogs

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Simon Fraser [no longer active]]

When OK/Cancel dialogs come up, focus is on the Cancel button (which seems wrong
in the first place). But the bad thing is that on Mac, both Return and Enter
buttons active the focussed widget, rather than the default button, so both end
up doing a 'Cancel'. This is just wrong.

Comment 1

[jag (Peter Annema)]

-> hewitt

Comment 2

[Simon Fraser [no longer active]]

I think that we're just focussing the first focussable thing, which happens to
be the Cancel button. I'm not sure that makes sense here. It's certainly wrong
to have Return/Enter do the focussed thing, rather than the default thing (on Mac).

Comment 3

[Boris Zbarsky [:bzbarsky]]

*** Bug 131865 has been marked as a duplicate of this bug. ***

Comment 4

[Boris Zbarsky [:bzbarsky]]

This is a major usability bug and an incredible annoyance for keyboard users...
 We should just handle this in the platform <dialog> bindings...

Comment 5

[Samir Gehani]

Nav triage team: nsbeta1+/adt2

Comment 6

[Brian King [:kinger]]

This bug bears *some* relation to bug #127892 where the opposite occurs on some
dialogs, but only those that use the dialogKeys keyset.

This bug appears to be a Mac only issue, and there is a Mac issue to be
addressed in 127892 as well.

Comment 7

[Peter Trudelle]

->bryner

Comment 8

[Brian Ryner (not reading)]

Attachment: make enter/return _always_ activate a default accept button on mac

This makes enter or return always activate a default accept button.  This is
what users will expect on the Mac since in native dialogs you can't actually
tab through the buttons.  Users can still tab to a button and press space to
activate it.

Comment 9

[Joe Hewitt (gone)]

Comment on attachment 82700 [details] [diff] [review]
make enter/return _always_ activate a default accept button on mac

r=hewitt

Comment 10

[Joe Hewitt (gone)]

*** Bug 139836 has been marked as a duplicate of this bug. ***

Comment 11

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 82700 [details] [diff] [review]
make enter/return _always_ activate a default accept button on mac

sr=[e-mail]

Comment 12

[Brian Ryner (not reading)]

Checked in on the trunk.

Comment 13

[Asa Dotzler [:asa]]

Comment on attachment 82700 [details] [diff] [review]
make enter/return _always_ activate a default accept button on mac

a=asa (on behalf of drivers) for checkin to the 1.0 branch

Comment 14

[Brian Ryner (not reading)]

Checked in on the branch.

Comment 15

[Boris Zbarsky [:bzbarsky]]

*** Bug 144180 has been marked as a duplicate of this bug. ***

Comment 16

[Jesse Ruderman]

*** Bug 130913 has been marked as a duplicate of this bug. ***

Comment 17

[Ed]

This bug still exists (or resurfaced) in FF on a mac

Comment 18

[Boris Zbarsky [:bzbarsky]]

Please file a new bug report, with clear steps to reproduce, and cc me on that bug report?

Comment 19

[Ed]

@boris, I don't see how to cc you from the new bug report. It is
https://bugzilla.mozilla.org/show_bug.cgi?id=1400362

Comment 20

[Ed]

@boris, I don't see how to cc you from the new bug report. It is
https://bugzilla.mozilla.org/show_bug.cgi?id=1400362

Comment 21

[Boris Zbarsky [:bzbarsky]]

Thanks, I'll follow up there.  That's about a different dialog than this bug.