1328009 - JSON viewer UI is broken after bug 1259819, bug 1289912, bug 1285863

Status: RESOLVED WORKSFORME

(DevTools :: JSON Viewer, defect, P3)

Description

[arni2033]

>>>   My Info:   Win7_64, Nightly 52, 32bit, ID 20161001030430 (2016-10-01)
Bad things that were broken:
1) "text" cursor above buttons JSON, Raw Data, Headers
2) Parts of scrollbars aren't visible:
 "Raw data" - right scrollbutton in horizontal scrollbar is invisible
 "Headers", "Raw Data" - scrollbar is placed below "the main scrollbar" and therefore unaccessible
 ("Raw data" - vertical scrollbar appears if I press "Pretty print" button)
3) "JSON" - Filter field isn't fully visible.
 If I paste a long string there, it moves all content to the right
4) Heiht of tabs in JSON viewer breaks if I switch between them:
 If I switch to "JSON" - then "Raw data" - then again "JSON" - "Raw Data" = raw data
 jumps by 40px to the bottom, horizontal scrollbar becomes invisible, and also
 "Raw Data" sets to itself the same height as "JSON". Then if I switch back to "JSON"
 again and close root item, right scrollbar is still visible.

JSON for testing:  https://hg.mozilla.org/mozilla-central/json-pushes?changeset=f8bdceb55c9d&full=1

This was broken 2 times.
1. Bug 1259819 (between 2016-07-16 and 2016-07-17): normal -> no scrollbar 
> pushlog https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=2f9e69c982f1e67887a1834b36ff0af4ababb3af&tochange=3db372da6fe108ddb0727003447f22c2483fb86d

2. Bug 1289912, bug 1285863 (between 2016-08-03 and 2016-08-04): no scrollbar -> all said bugs
> pushlog https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=474f38fc48be9f97b49b084ebf0b59293b81cf16&tochange=555caa0082c342c60830261ecba4c4068122207e

Comment 1

[Zac Svoboda :zacnomore]

I went through and retested these issues. One of them I couldn't understand but the others are resolved.

(In reply to arni2033 from comment #0)

My Info: Win7_64, Nightly 52, 32bit, ID 20161001030430 (2016-10-01)
Bad things that were broken:

1. "text" cursor above buttons JSON, Raw Data, Headers

Resolved, no cursor above buttons

2. Parts of scrollbars aren't visible:
   "Raw data" - right scrollbutton in horizontal scrollbar is invisible

Resolved, scrollbar appears in raw data tab

"Headers", "Raw Data" - scrollbar is placed below "the main scrollbar" and
therefore unaccessible

Not sure what this means. The scrollbar appears on .panelContent, I'm not seeing an accessibility issue with that.

("Raw data" - vertical scrollbar appears if I press "Pretty print" button)

Resolved, scrollbar appears both before and after pretty printing.

3. "JSON" - Filter field isn't fully visible.
   If I paste a long string there, it moves all content to the right

Resolved, not seeing any impact on layout when using a long search string.

4. Heiht of tabs in JSON viewer breaks if I switch between them:
   If I switch to "JSON" - then "Raw data" - then again "JSON" - "Raw Data" =
   raw data
   jumps by 40px to the bottom, horizontal scrollbar becomes invisible, and
   also
   "Raw Data" sets to itself the same height as "JSON". Then if I switch back
   to "JSON"
   again and close root item, right scrollbar is still visible.

Resolved, not seeing any "wiggle" in the tabs when switching between them

With all that said, the reporter's account is disabled so I don't think we'll be getting clarification.
Honza, if you feel I've interpreted this bug correctly, can we close this as resolved?

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thank you Zachary for the testing!

Yes arni2033 account has been disabled long time ago and we won't get response from the reporter.

I am closing this report.