1328034 - Findbar highlights old match when I search for new string and toggle Highlight All

Status: NEW

(Toolkit :: Find Toolbar, defect, P3)

Description

[arni2033]

>>>   My Info:   Win7_64, Nightly 52, 32bit, ID 20161028030204 (2016-10-28)
STR_1:
1. Open url   data:,Firefox regressions since version 28
2. Open findbar, type "regression" in findbar
3. Select "e" in word "since"
4. Press Ctrl+F
5. Enable "Highlight All"

AR:  Step 3 - "regression" is not highlighted.  Step 5 - "regression" is highlighted
ER:  Step 5 - "regression" shouldn't be highlighted

This is regression between good old Firefox 28 and Nightly 2016-10-28

Comment 1

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Narrowed inbound regression window from [b7731992, 1262d39d] (3 revisions) to [b7731992, a3358902] (2 revisions) (~1 steps left)
Oh noes, no (more) inbound revisions :(
Last good revision: b773199257dc43a4ed4ded8f41dc01f12e2ba222
First bad revision: a3358902819df2748f4fea811da37c57c1283293
Pushlog:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=b773199257dc43a4ed4ded8f41dc01f12e2ba222&tochange=a3358902819df2748f4fea811da37c57c1283293

Looks like the following bug has the changes which introduced the regression:
https://bugzilla.mozilla.org/show_bug.cgi?id=1294644

Mike, can you take a look at this?

Comment 2

[castiel743]

This bug should be marked as blocking bug 1316516, for tracking purposes.

Comment 3

[Gerry Chang [:gchang]]

Mark 51 fix-optional as there are no actions for the moment.

Comment 4

[Andrew Overholt [:overholt]]

Attachment: findbar-whatIsee.png

This is what I see in today's nightly on Windows 10.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

This only affects the new findbar, which is still Nightly-only.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

I was mistaken, this affects the old findbar as well (reproduced it just now with Fx 52.0.2). Mike, can you please take a look?

Comment 7

[alex_mayorga]

Attachment: find-bug.PNG

¡Hola!

Is what shows on find-bug.png (attached) this bug or a different one?

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0 ID:20170412030252 CSet: f40e24f40b4c4556944c762d4764eace261297f5

¡Gracias!
Alex

Comment 8

[Mike de Boer [:mikedeboer]]

Different one, that's bug 1302470.