Closed
Bug 1328321
Opened 9 years ago
Closed 7 years ago
Fix test_lowDiskSpace.html now that it runs in a different suite
Categories
(Core :: Storage: IndexedDB, defect, P3)
Core
Storage: IndexedDB
Tracking
()
RESOLVED
INVALID
People
(Reporter: ntim, Unassigned)
References
Details
Without new test from bug 1322938:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=58be2978aaa43070024c32bcf6dc8249cb3c92c8&selectedJob=65874028
Runs in 10.
With new test:
https://treeherder.mozilla.org/logviewer.html#?job_id=40991023&repo=mozilla-inbound
Runs in 11, and fails intermittently.
Comment 1•8 years ago
|
||
Jan/Bevis, can you take a look? Seems the on-disk conditions have changed now that the mochitest group it's in has changed.
Flags: needinfo?(jvarga)
Flags: needinfo?(btseng)
Priority: -- → P3
Comment 2•8 years ago
|
||
I didn't find any clue that the change of mochitest-group could cause this assertion.
However, from the call stack, it is weird that the value of IndexedDatabaseManager::InLowDiskSpaceMode() was false at the beginning of CreateIndexOp::DoDatabaseWork() [1] but became true when running into CreateIndexOp::InsertDataFromObjectStore()[2].
This is not expected according to the test flow in test_lowDiskSpace.js where *LowDiskSpaceMode* will only be changed after db operation is complete [3]. (Unless it was changed outside the script or the IDBOpenRequest.onsuccess was fired too early before IDBObjectStore.createIndex is done.)
I'll take this bug to look into it.
[1] http://searchfox.org/mozilla-central/rev/848c29538ab007fb95dc6cff194f0e3d3809613d/dom/indexedDB/ActorsParent.cpp#24668
[2] http://searchfox.org/mozilla-central/rev/848c29538ab007fb95dc6cff194f0e3d3809613d/dom/indexedDB/ActorsParent.cpp#24761
[3] http://searchfox.org/mozilla-central/rev/848c29538ab007fb95dc6cff194f0e3d3809613d/dom/indexedDB/test/unit/test_lowDiskSpace.js#268-280
Assignee: nobody → btseng
Flags: needinfo?(btseng)
Updated•8 years ago
|
Flags: needinfo?(jvarga)
Updated•7 years ago
|
Assignee: btseng → nobody
Comment 3•7 years ago
|
||
This test was removed in bug 1488401.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•