Closed Bug 1328519 Opened 4 years ago Closed 3 years ago

Redefine the width of downloadDetails.width in the L10N file (downloads.dtd) for Downloads Panel

Categories

(Firefox :: Downloads Panel, defect, P1)

x86
All
defect
Points:
5

Tracking

()

RESOLVED FIXED
Firefox 64
Tracking Status
firefox64 --- fixed

People

(Reporter: selee, Assigned: Paolo)

References

Details

(Whiteboard: [CHE-BACKLOG])

Attachments

(1 file)

The width of downloadDetails.width in the L10N file (downloads.dtd) should be refined to be fulfill the latest design of Downloads Panel including:
1. The original downloadDetails string.
2. The string when hover on an item.
3. The string when hover on an action button.

(In reply to :Paolo Amadini from comment #48)
> Comment on attachment 8817589 [details]
> Bug 812894 - Use the short time format for downloading remaining time.;
> 
> https://reviewboard.mozilla.org/r/97820/#review98604
> 
> ::: browser/locales/en-US/chrome/browser/downloads/downloads.dtd:26
> (Diff revision 2)
> >  
> > -     59 minutes, 59 seconds remaining - 1022 of 1023 KB
> > +     59m 59s left - 1022 of 1023 KB (120.5 KB/sec)
> >  
> > -     That's 50 characters, so we set the width at 50ch.
> > +     That's 45 characters, so we set the width at 45ch.
> >       -->
> > -<!ENTITY downloadDetails.width            "50ch">
> > +<!ENTITY downloadDetails.width            "45ch">
> 
> We should keep the current value even if the string for in-progress
> downloads is shorter, because the strings for blocked downloads and the new
> labels we are adding for hover cases may be longer.
> 
> In fact, the way the rule is explained in the comment is not that useful. We
> can update the comment for now to explain, but we may actually consider
> redefining these widths in a separate bug at some point.
>
When doing this, we can simplify how this width is defined. Instead of changing the font size on the entire item and reverting it for the file name, we can just make the font size smaller for the details label. In fact, if I understand correctly, the current solution was implemented to keep this width unchanged and keep the result slightly different on various platforms, which is probably unnecessary.
Priority: -- → P3
Whiteboard: [CHE-BACKLOG]
Assignee: nobody → paolo.mozmail
Blocks: 1452626
Status: NEW → ASSIGNED
Priority: P3 → P1
The width is now defined on the entire list instead of the inner elements, similarly to other Photon panels like the main menu. This is a prerequisite for preventing layout issues while removing the "download" binding.
Comment on attachment 9010351 [details]
Bug 1328519 - Simplify the definition of the Downloads Panel width. r=mak

Marco Bonardo [::mak] has approved the revision.
Attachment #9010351 - Flags: review+
Pushed by paolo.mozmail@amadzone.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/83ab7c05f538
Simplify the definition of the Downloads Panel width. r=mak
https://hg.mozilla.org/mozilla-central/rev/83ab7c05f538
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in before you can comment on or make changes to this bug.