Remove the "download" binding

RESOLVED FIXED in Firefox 64

Status

()

P1
normal
RESOLVED FIXED
a year ago
4 months ago

People

(Reporter: Paolo, Assigned: Paolo)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 64
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox61 wontfix, firefox62 wontfix, firefox63 wontfix, firefox64 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
The "download" binding is used by the Downloads Panel, the Downloads View in the Library window, and the in-content Downloads View.

This can probably be converted to a Custom Element, or maybe just a plain JavaScript class if we need either lazy construction or binding to a "richlistitem".
(Assignee)

Updated

a year ago
Depends on: 1452629
(Assignee)

Updated

a year ago
Priority: -- → P3
(Assignee)

Updated

6 months ago
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
Priority: P3 → P1
(Assignee)

Updated

6 months ago
Depends on: 1328519
(Assignee)

Updated

6 months ago
Depends on: 1493969
(Assignee)

Comment 1

6 months ago
Depends on D4539
Comment on attachment 9012876 [details]
Bug 1452626 - Remove the "download" binding. r=mak,bgrins

Brian Grinstead [:bgrins] has approved the revision.
Attachment #9012876 - Flags: review+
This is unexpected: EST-UNEXPECTED-FAIL | browser/components/places/tests/browser/browser_library_downloads.js | leaked 1 window(s) until shutdown [url = chrome://browser/content/places/places.xul]
(Assignee)

Comment 5

6 months ago
Thanks for calling attention to the leak, in fact it was due to the fragment being cached globally. While the fragment can be cloned to any document, in fact independent from the original, maybe the fact that it's been created by a particular document's DOMParser is enough to keep that document alive.

Comment 7

6 months ago
Pushed by paolo.mozmail@amadzone.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2614ca0a8884
Remove the "download" binding. r=mak,bgrins

Comment 8

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2614ca0a8884
Status: ASSIGNED → RESOLVED
Last Resolved: 6 months ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
status-firefox61: affected → wontfix
status-firefox62: --- → wontfix
status-firefox63: --- → wontfix

Updated

4 months ago
Depends on: 1513149
You need to log in before you can comment on or make changes to this bug.