1452626 - Remove the "download" binding

Status: RESOLVED FIXED

(Firefox :: Downloads Panel, task, P1)

Description

[:Paolo Amadini]

The "download" binding is used by the Downloads Panel, the Downloads View in the Library window, and the in-content Downloads View.

This can probably be converted to a Custom Element, or maybe just a plain JavaScript class if we need either lazy construction or binding to a "richlistitem".

Comment 1

[:Paolo Amadini]

Attachment: Bug 1452626 - Remove the "download" binding. r=mak,bgrins

Depends on D4539

Comment 2

[:Paolo Amadini]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6ec09d902dd87161f94a61494342c46517195bd2

Comment 3

[Brian Grinstead [:bgrins]]

Comment on attachment 9012876 [details]
Bug 1452626 - Remove the "download" binding. r=mak,bgrins

Brian Grinstead [:bgrins] has approved the revision.

Comment 4

[Marco Bonardo [:mak]]

This is unexpected: EST-UNEXPECTED-FAIL | browser/components/places/tests/browser/browser_library_downloads.js | leaked 1 window(s) until shutdown [url = chrome://browser/content/places/places.xul]

Comment 5

[:Paolo Amadini]

Thanks for calling attention to the leak, in fact it was due to the fragment being cached globally. While the fragment can be cloned to any document, in fact independent from the original, maybe the fact that it's been created by a particular document's DOMParser is enough to keep that document alive.

Comment 6

[:Paolo Amadini]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1fb023ebb210d7444b188de6f2fe9da64961430a

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2614ca0a8884
Remove the "download" binding. r=mak,bgrins

Comment 8

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/2614ca0a8884