Closed Bug 1452626 Opened 2 years ago Closed 2 years ago

Remove the "download" binding

Categories

(Firefox :: Downloads Panel, task, P1)

task

Tracking

()

RESOLVED FIXED
Firefox 64
Tracking Status
firefox61 --- wontfix
firefox62 --- wontfix
firefox63 --- wontfix
firefox64 --- fixed

People

(Reporter: Paolo, Assigned: Paolo)

References

Details

Attachments

(1 file)

The "download" binding is used by the Downloads Panel, the Downloads View in the Library window, and the in-content Downloads View.

This can probably be converted to a Custom Element, or maybe just a plain JavaScript class if we need either lazy construction or binding to a "richlistitem".
Depends on: 1452629
Priority: -- → P3
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
Priority: P3 → P1
Depends on: 1328519
Depends on: 1493969
Depends on D4539
Comment on attachment 9012876 [details]
Bug 1452626 - Remove the "download" binding. r=mak,bgrins

Brian Grinstead [:bgrins] has approved the revision.
Attachment #9012876 - Flags: review+
This is unexpected: EST-UNEXPECTED-FAIL | browser/components/places/tests/browser/browser_library_downloads.js | leaked 1 window(s) until shutdown [url = chrome://browser/content/places/places.xul]
Thanks for calling attention to the leak, in fact it was due to the fragment being cached globally. While the fragment can be cloned to any document, in fact independent from the original, maybe the fact that it's been created by a particular document's DOMParser is enough to keep that document alive.
Pushed by paolo.mozmail@amadzone.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2614ca0a8884
Remove the "download" binding. r=mak,bgrins
https://hg.mozilla.org/mozilla-central/rev/2614ca0a8884
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Depends on: 1513149
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.