Closed
Bug 1452626
Opened 6 years ago
Closed 5 years ago
Remove the "download" binding
Categories
(Firefox :: Downloads Panel, task, P1)
Firefox
Downloads Panel
Tracking
()
RESOLVED
FIXED
Firefox 64
People
(Reporter: Paolo, Assigned: Paolo)
References
(Regressed 1 open bug)
Details
Attachments
(1 file)
The "download" binding is used by the Downloads Panel, the Downloads View in the Library window, and the in-content Downloads View. This can probably be converted to a Custom Element, or maybe just a plain JavaScript class if we need either lazy construction or binding to a "richlistitem".
Assignee | ||
Updated•6 years ago
|
Priority: -- → P3
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
Priority: P3 → P1
Assignee | ||
Comment 1•5 years ago
|
||
Depends on D4539
Assignee | ||
Comment 2•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6ec09d902dd87161f94a61494342c46517195bd2
Comment 3•5 years ago
|
||
Comment on attachment 9012876 [details] Bug 1452626 - Remove the "download" binding. r=mak,bgrins Brian Grinstead [:bgrins] has approved the revision.
Attachment #9012876 -
Flags: review+
Comment 4•5 years ago
|
||
This is unexpected: EST-UNEXPECTED-FAIL | browser/components/places/tests/browser/browser_library_downloads.js | leaked 1 window(s) until shutdown [url = chrome://browser/content/places/places.xul]
Assignee | ||
Comment 5•5 years ago
|
||
Thanks for calling attention to the leak, in fact it was due to the fragment being cached globally. While the fragment can be cloned to any document, in fact independent from the original, maybe the fact that it's been created by a particular document's DOMParser is enough to keep that document alive.
Assignee | ||
Comment 6•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1fb023ebb210d7444b188de6f2fe9da64961430a
Pushed by paolo.mozmail@amadzone.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/2614ca0a8884 Remove the "download" binding. r=mak,bgrins
Comment 8•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2614ca0a8884
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Updated•5 years ago
|
status-firefox62:
--- → wontfix
status-firefox63:
--- → wontfix
Updated•5 years ago
|
Type: enhancement → task
You need to log in
before you can comment on or make changes to this bug.
Description
•