Closed Bug 1452626 Opened 5 years ago Closed 4 years ago
Remove the "download" binding
46 bytes, text/x-phabricator-request
|Details | Review|
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
Priority: P3 → P1
Depends on D4539
Comment on attachment 9012876 [details] Bug 1452626 - Remove the "download" binding. r=mak,bgrins Brian Grinstead [:bgrins] has approved the revision.
Attachment #9012876 - Flags: review+
This is unexpected: EST-UNEXPECTED-FAIL | browser/components/places/tests/browser/browser_library_downloads.js | leaked 1 window(s) until shutdown [url = chrome://browser/content/places/places.xul]
Thanks for calling attention to the leak, in fact it was due to the fragment being cached globally. While the fragment can be cloned to any document, in fact independent from the original, maybe the fact that it's been created by a particular document's DOMParser is enough to keep that document alive.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/2614ca0a8884 Remove the "download" binding. r=mak,bgrins
You need to log in before you can comment on or make changes to this bug.