1328557 - [SeaMonkey] Searchbar regression: No separator between datalist and form history entries

Status: RESOLVED FIXED

(SeaMonkey :: Search, defect)

Description

[Philip Chee]

In SeaMonkey we are still using a xul:tree however:
1. There is no horizontal separator between the form history and suggestions.
2. The "Suggestions" text in the separator row is not styled differently e.g.

  color: GrayText;
  font-size: smaller;

+++ This bug was initially created as a clone of Bug #1311189 +++

> When a field has autocomplete results including both datalist and form history 
> entries, we generally put the form history entries at the top, then a 
> horizontal separator, and then the datalist entries.

SeaMonkey should still do that.

Comment 1

[Philip Chee]

What the drop-list in SeaMonkey used to look like and should but doesn't currently:
attachment 723720 [details]

> In SeaMonkey we are still using a xul:tree however:
> 1. There is no horizontal separator between the form history and suggestions.
> 2. The "Suggestions" text in the separator row is not styled differently e.g.
> 
>   color: GrayText;
>   font-size: smaller;

> SeaMonkey should still do that.

Comment 2

[Philip Chee]

Managed to fix it at my end.

Comment 3

[Philip Chee]

Attachment: Patch v1.0 Fix fallout from Bug 1311189, Bug 1296638, and Bug 1300547.

Fix fallout from Bug 1311189, Bug 1296638, and Bug 1300547.

Bug 1311189 - No separator between datalist and form history entries with richlistbox implementation [Toolkit]
Bug 1296638 - Switch toolkit Form Autocomplete popup from using a <xul:tree> to using a <xul:richlistbox>
Bug 1300547 - Suggestion list dropdown with suggestions not shown [SeaMonkey]

Minor search widget tweaks:
Bug 344536 - Limit the number of history items displayed the search bar history dropdown, so that some suggestions are always visible.
  added comment only
Bug 1008182 - remove the delay for searchbar autocomplete
  removed timeout="250"
Bug 1239319 - use input types properly for search and url bar to get better OSK support on Windows
  added inputtype="search"

> +++ b/suite/common/search/search-panel.xul
> +    <popupset id="sidebarPopupset">
> +      <panel id="PopupAutoComplete"
> +             type="autocomplete"
> +             noautofocus="true"/>
> +    </popupset>
> +
>      <menulist id="sidebar-search-engines"
>                oncommand="SelectEngine(this);"/>
 
>      <hbox align="center">
>        <textbox id="sidebar-search-text" flex="1"
>                 class="search-textbox padded"
>                 ontextentered="doSearch();"
>                 placeholder="&search.placeholder;"
>                 type="autocomplete"
> +               inputtype="search"
> +               autocompletepopup="PopupAutoComplete"

Sidebar search widget was not showing search suggestions.

+++ b/suite/common/search/search.xml
-                   autocompletepopup="PopupAutoComplete"
+                   autocompletepopup="_child"
.....
+        <xul:panel anonid="searchPopupAutoComplete"
+                   type="autocomplete"
+                   noautofocus="true"/>

frg turned the PopupAutoComplete into a "autocomplete-richlistbox" for the urlbar. But this doesn't work for our searchbar widget. Move the old autocomplete panel to search.xml and make the searchbar widget use this instead.

> +++ b/suite/themes/classic/communicator/search/search.css
> -.autocomplete-treebody::-moz-tree-cell(suggesthint) {
> +.autocomplete-treebody::-moz-tree-cell(datalist-first)
"suggesthint" is now "datalist-first".

> +++ b/suite/themes/classic/communicator/search/searchbar.css
> +/* ::::: search bar ::::: */
> +
> +.autocomplete-treebody::-moz-tree-cell-text(datalist-first, treecolAutoCompleteComment) {
> +  color: GrayText;
> +  font-size: smaller;
> +}
> +
> +.autocomplete-treebody::-moz-tree-cell(datalist-first) {
> +  border-top: 1px solid GrayText;
> +}
Moved from navigator.css

> +++ b/suite/themes/classic/navigator/navigator.css
> -/* ::::: search bar ::::: */
> -
> -.autocomplete-treebody::-moz-tree-cell-text(suggesthint, treecolAutoCompleteComment),
> -.autocomplete-treebody::-moz-tree-cell-text(suggestfirst, treecolAutoCompleteComment) {
> -  color: GrayText;
> -  font-size: smaller;
> -}
> -
> -.autocomplete-treebody::-moz-tree-cell(suggesthint) {
> -  border-top: 1px solid GrayText;
> -}
Moved to searchbar.css

Comment 4

[Ian Neal]

Comment on attachment 8823817 [details] [diff] [review]
Patch v1.0 Fix fallout from Bug 1311189, Bug 1296638, and Bug 1300547.

r/a=me

Comment 5

[Philip Chee]

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/8ea39bd5a173bdcf509b274056c2c1ebd1fb79d3

Comment 6

[Philip Chee]

Comment on attachment 8823817 [details] [diff] [review]
Patch v1.0 Fix fallout from Bug 1311189, Bug 1296638, and Bug 1300547.

[Approval Request Comment]
Regression caused by (bug #): Bug 1311189, Bug 1296638, and Bug 1300547.
Bug 1311189 and Bug 1296638 landed in Firefox 52. So we need to backport this to SeaMonkey 2.49.

SeaMonkey Bug 1300547 fixes a problem in the urlbar (at 2.50) but incorrectly affects other search widgets. The fixes here are applicable to 2.49 as correctness fixes.

User impact if declined: No separator between search suggestions and form history entries

Testing completed (on m-c, etc.): comm-central.

Risk to taking this patch (and alternatives if risky): low to none. Regression fix, so it can't get worse, only better.

String changes made by this patch: none.

Comment 7

[Ian Neal]

Comment on attachment 8823817 [details] [diff] [review]
Patch v1.0 Fix fallout from Bug 1311189, Bug 1296638, and Bug 1300547.

a=me

Comment 8

[Philip Chee]

Pushed to comm-aurora. (SeaMonkey 2.49)
http://hg.mozilla.org/releases/comm-beta/rev/1501fe94aa68