1328806 - stylo: Map more Gecko state bits to Servo state bits

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Xidorn Quan [:xidorn] UTC+10]

Currently we only map the first seven state bits from Gecko to Servo (the state bits for :active, :focus, :hover, :enabled, :disabled, :checked, :indeterminate), but it seems to me we can actually map more.

The rests are:
IN_READ_WRITE_STATE => NS_EVENT_STATE_MOZ_READWRITE (incomplete)
IN_PLACEHOLDER_SHOWN_STATE => NS_EVENT_STATE_PLACEHOLDERSHOWN
IN_TARGET_STATE => NS_EVENT_STATE_URLTARGET
IN_FULLSCREEN_STATE => NS_EVENT_STATE_FULL_SCREEN

Looks like we have everything Servo currently supports. :read-write may need more investigation given bug 312971, but I guess it shouldn't be harmful to map them together.

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1328806 - Map more state bits from Gecko to Servo.

Review commit: https://reviewboard.mozilla.org/r/102518/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/102518/

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5e63be85c717
Map more state bits from Gecko to Servo. r=bholley

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

https://github.com/servo/servo/pull/14872

Comment 4

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/5e63be85c717