Closed Bug 1328806 Opened 3 years ago Closed 3 years ago

stylo: Map more Gecko state bits to Servo state bits

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

Details

Attachments

(1 file)

Currently we only map the first seven state bits from Gecko to Servo (the state bits for :active, :focus, :hover, :enabled, :disabled, :checked, :indeterminate), but it seems to me we can actually map more.

The rests are:
IN_READ_WRITE_STATE => NS_EVENT_STATE_MOZ_READWRITE (incomplete)
IN_PLACEHOLDER_SHOWN_STATE => NS_EVENT_STATE_PLACEHOLDERSHOWN
IN_TARGET_STATE => NS_EVENT_STATE_URLTARGET
IN_FULLSCREEN_STATE => NS_EVENT_STATE_FULL_SCREEN

Looks like we have everything Servo currently supports. :read-write may need more investigation given bug 312971, but I guess it shouldn't be harmful to map them together.
Blocks: 1328513
Attachment #8824011 - Flags: review?(cam) → review+
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5e63be85c717
Map more state bits from Gecko to Servo. r=bholley
https://github.com/servo/servo/pull/14872
Assignee: nobody → xidorn+moz
https://hg.mozilla.org/mozilla-central/rev/5e63be85c717
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.