stylo: fullscreen-related tests crash due to lack of -moz-top-layer support

RESOLVED FIXED

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: xidorn, Assigned: xidorn)

Tracking

(Blocks: 1 bug)

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 affected)

Details

(Assignee)

Description

a year ago
layout/style/test/chrome/test_display_mode.html
layout/style/test/chrome/test_display_mode_reflow.html
Nazim, got any cycles to add -moz-top-layer support?
Flags: needinfo?(canaltinova)
(Assignee)

Comment 2

a year ago
Note that -moz-top-layer is a property only available to ua sheet. Allowing web content to touch it would lead to breaking other assertions.
(Assignee)

Comment 3

a year ago
I tried to implement -moz-top-layer myself (since I implemented it for Gecko so more familiar with it). Then it seems the me those tests would continus crashing because of incorrect element state bits mapping.
Flags: needinfo?(canaltinova)
(Assignee)

Comment 4

a year ago
We also need to correct apply :fullscreen pseudo-class to have the -moz-top-layer property set.
Depends on: 1328806
(Assignee)

Comment 5

a year ago
https://github.com/servo/servo/pull/14857

But this is not enough. Servo also need to recognize :-moz-browser-frame pseudo-class to stop crashing fullscreen.
(Assignee)

Updated

a year ago
Depends on: 1329076
(Assignee)

Updated

a year ago
Assignee: nobody → xidorn+moz
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.