1328851 - Enable eslint rule no-undef for storage/

Status: RESOLVED FIXED

(Core :: SQLite and Embedded Database Bindings, defect)

Description

[Mark Banner (:standard8)]

This is part of the ongoing work to enable the no-undef eslint rule. The storage directory is quite easy to enable, mainly being just tests, so we should do that.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1328851 - Enable eslint rule no-undef for storage/.

Review commit: https://reviewboard.mozilla.org/r/102560/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/102560/

Comment 2

[Marco Bonardo [:mak]]

Comment on attachment 8824038 [details]
Bug 1328851 - Enable eslint rule no-undef for storage/.

https://reviewboard.mozilla.org/r/102560/#review102938

::: storage/test/unit/test_statement_executeAsync.js:10
(Diff revision 1)
>  /*
>   * This file tests the functionality of mozIStorageBaseStatement::executeAsync
>   * for both mozIStorageStatement and mozIStorageAsyncStatement.
>   */
>  
> +// This file uses the intenal _quit from testing/xpcshell/head.js */

typo: intenal?

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8824038 [details]
Bug 1328851 - Enable eslint rule no-undef for storage/.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/102560/diff/1-2/

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 8824038 [details]
Bug 1328851 - Enable eslint rule no-undef for storage/.

https://reviewboard.mozilla.org/r/102560/#review102938

> typo: intenal?

Thanks for catching that, I somehow saw it but forgot to fix it.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c081650eddf
Enable eslint rule no-undef for storage/. r=mak

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7c081650eddf