If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Enable eslint rule no-undef for storage/

RESOLVED FIXED in Firefox 53

Status

()

Toolkit
Storage
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

unspecified
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

9 months ago
This is part of the ongoing work to enable the no-undef eslint rule. The storage directory is quite easy to enable, mainly being just tests, so we should do that.
Comment hidden (mozreview-request)

Comment 2

9 months ago
mozreview-review
Comment on attachment 8824038 [details]
Bug 1328851 - Enable eslint rule no-undef for storage/.

https://reviewboard.mozilla.org/r/102560/#review102938

::: storage/test/unit/test_statement_executeAsync.js:10
(Diff revision 1)
>  /*
>   * This file tests the functionality of mozIStorageBaseStatement::executeAsync
>   * for both mozIStorageStatement and mozIStorageAsyncStatement.
>   */
>  
> +// This file uses the intenal _quit from testing/xpcshell/head.js */

typo: intenal?
Attachment #8824038 - Flags: review?(mak77) → review+
Comment hidden (mozreview-request)
(Assignee)

Comment 4

9 months ago
mozreview-review-reply
Comment on attachment 8824038 [details]
Bug 1328851 - Enable eslint rule no-undef for storage/.

https://reviewboard.mozilla.org/r/102560/#review102938

> typo: intenal?

Thanks for catching that, I somehow saw it but forgot to fix it.

Comment 5

9 months ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7c081650eddf
Enable eslint rule no-undef for storage/. r=mak

Comment 6

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7c081650eddf
Status: NEW → RESOLVED
Last Resolved: 9 months ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.