1328897 - Update Google Search Plugin (sync with Firefox) [20161231]

Status: RESOLVED FIXED

(SeaMonkey :: Search, defect)

Description

[Philip Chee]

Update logo etc.

Comment 1

[Philip Chee]

Attachment: Patch v1.0

> -<Image width="16" height="16">data:image/png;base64...
> +<Image width="16" height="16">data:image/x-icon;base64...
Switch to ico so can contain a 16x16 as well as a 32x32 image.
See Bug 795495 - Use 32x32 search engine icons in HiDPI mode when available
Also See Bug 1201770 - Update Google icon for Search (new logo - again!)

> -  <Param name="aq" value="t"/>
> -  <!-- Dynamic parameters -->
> -  <Param name="rls" value="{moz:distributionID}:{moz:locale}:{moz:official}"/>
> -  <MozParam name="client" condition="defaultEngine" trueValue="seamonkey-a" falseValue="seamonkey"/>
End of search agreement with Google. See:
Bug 1103216 - Remove affiliate codes from default Google plugin in en-US (update Google parameters)
Bug 1181645 - Default invalid or empty purpose in getSubmission to searchbar
  (caused by Bug 1264786 - Update Google search plugin)

> +  <MozParam name="client" condition="purpose" purpose="keyword" value="seamonkey-b-ab"/>
> +  <MozParam name="client" condition="purpose" purpose="searchbar" value="seamonkey-b"/>
Do we want these? They exist solely for telemetry/firefox health report and we don't have and telemetry at all and besides we don't have any search agreement with Google so even with telemetry this is rather useless.

Comment 2

[Ian Neal]

Comment on attachment 8824093 [details] [diff] [review]
Patch v1.0

>+++ b/suite/locales/en-US/searchplugins/google.xml
> <Url type="text/html" method="GET" template="https://www.google.com/search">
Firefox has one more attribute here, rel="searchform" and not the final <Url> section.
>   <Param name="q" value="{searchTerms}"/>
>   <Param name="ie" value="utf-8"/>
>   <Param name="oe" value="utf-8"/>
>-  <Param name="aq" value="t"/>
>-  <!-- Dynamic parameters -->
>-  <Param name="rls" value="{moz:distributionID}:{moz:locale}:{moz:official}"/>
>-  <MozParam name="client" condition="defaultEngine" trueValue="seamonkey-a" falseValue="seamonkey"/>
>+  <MozParam name="client" condition="purpose" purpose="keyword" value="seamonkey-b-ab"/>
>+  <MozParam name="client" condition="purpose" purpose="searchbar" value="seamonkey-b"/>
Yes, drop these two.

> </Url>
> <Url type="text/html"
>      method="GET"
>      template="https://www.google.com/"
>      rel="searchform"/>
This section is no longer in the Firefox version.

> </SearchPlugin>

r/a=me with those addressed.

Comment 3

[Philip Chee]

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/58012bab36b2ada838ab83d6ec4f805b345c4a6f