Closed Bug 1328990 Opened 3 years ago Closed 3 years ago

Convert FormAssistPopup events to bundle events

Categories

(GeckoView :: General, defect)

All
Android
defect
Not set

Tracking

(firefox53 fixed)

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: jchen, Assigned: jchen)

References

Details

Attachments

(1 file)

No description provided.
Convert "FormAssist:*" events in FormAssistPopup to
GeckoBundle/BundleEventListener events.  UI thread events are used
because the listener performs operations on the UI thread.

Also convert the "FormAssist:*" observers in browser.js to use
WindowEventDispatcher.

The "FormAssist:AutoComplete" event that goes from Gecko to Java is
renamed to "FormAssist:AutoCompleteResult" to prevent conflict with the
event with the same name that goes from Java to Gecko.
Attachment #8826013 - Flags: review?(s.kaspari)
Comment on attachment 8826013 [details] [diff] [review]
Convert FormAssistPopup events to bundle events (v1)

Review of attachment 8826013 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/java/org/mozilla/gecko/FormAssistPopup.java
@@ -266,5 @@
> -            mH = rect.getDouble("h");
> -        } catch (JSONException e) {
> -            // Bail if we can't get the correct dimensions for the popup.
> -            Log.e(LOGTAG, "Error getting FormAssistPopup dimensions", e);
> -            return false;

I wonder if we are going to see some new crashes because we almost always caught (not only here) and logged JSON errors. So we never really saw if there are issues here in the wild - but let's fix them as they come  up.
Attachment #8826013 - Flags: review?(s.kaspari) → review+
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2823e4d46cf5
Convert FormAssistPopup events to bundle events; r=sebastian
https://hg.mozilla.org/mozilla-central/rev/2823e4d46cf5
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Product: Firefox for Android → GeckoView
Target Milestone: Firefox 53 → mozilla53
You need to log in before you can comment on or make changes to this bug.