1328991 - Convert ZoomedView events to bundle events

Status: RESOLVED FIXED

(GeckoView :: General, defect)

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Convert ZoomedView events to bundle events (v1)

Convert events used in ZoomedView to GeckoBundle/BundleEventListener
events.

"Window:Resize", "Browser:ZoomToPageWidth", and
"Browser:ZoomToRect" listeners are removed because they are not sent
anywhere.

The "Content:LocationChange" listener is merged into the
"Gesture:CloseZoomedView" listener, so that we can leave
"Content:LocationChange" alone for now. Otherwise we would have to
convert the "Content:LocationChange" listener in Tabs as well.

The listeners are changed from global listeners to per-GeckoApp
listeners, because two of the events, "FormAssist:AutoCompleteResult" and
"FormAssist:Hide", are per-GeckoApp events also used by FormAssistPopup.
Because the events are now per-GeckoApp events, they are now registered
from onAttachedToWindow and onDetachedFromWindow.

Comment 2

[Jan Henning [:JanH]]

(In reply to Jim Chen [:jchen] [:darchons] from comment #1)
> "Window:Resize", "Browser:ZoomToPageWidth", and
> "Browser:ZoomToRect" listeners are removed because they are not sent
> anywhere.

Those are probably pre-APZ events that were never fixed up because the Zoomed View was deactivated in the period between APZ landing and it becoming the default.

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8826014 [details] [diff] [review]
Convert ZoomedView events to bundle events (v1)

Review of attachment 8826014 [details] [diff] [review]:
-----------------------------------------------------------------

Eventually this will get killed (bug 1330594).

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3b8de0c771e4
Convert ZoomedView events to bundle events; r=sebastian

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3b8de0c771e4