Closed Bug 1328991 Opened 3 years ago Closed 3 years ago

Convert ZoomedView events to bundle events

Categories

(GeckoView :: General, defect)

All
Android
defect
Not set

Tracking

(firefox53 fixed)

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: jchen, Assigned: jchen)

References

Details

Attachments

(1 file)

No description provided.
Convert events used in ZoomedView to GeckoBundle/BundleEventListener
events.

"Window:Resize", "Browser:ZoomToPageWidth", and
"Browser:ZoomToRect" listeners are removed because they are not sent
anywhere.

The "Content:LocationChange" listener is merged into the
"Gesture:CloseZoomedView" listener, so that we can leave
"Content:LocationChange" alone for now. Otherwise we would have to
convert the "Content:LocationChange" listener in Tabs as well.

The listeners are changed from global listeners to per-GeckoApp
listeners, because two of the events, "FormAssist:AutoCompleteResult" and
"FormAssist:Hide", are per-GeckoApp events also used by FormAssistPopup.
Because the events are now per-GeckoApp events, they are now registered
from onAttachedToWindow and onDetachedFromWindow.
Attachment #8826014 - Flags: review?(s.kaspari)
(In reply to Jim Chen [:jchen] [:darchons] from comment #1)
> "Window:Resize", "Browser:ZoomToPageWidth", and
> "Browser:ZoomToRect" listeners are removed because they are not sent
> anywhere.

Those are probably pre-APZ events that were never fixed up because the Zoomed View was deactivated in the period between APZ landing and it becoming the default.
See Also: → 1330594
Comment on attachment 8826014 [details] [diff] [review]
Convert ZoomedView events to bundle events (v1)

Review of attachment 8826014 [details] [diff] [review]:
-----------------------------------------------------------------

Eventually this will get killed (bug 1330594).
Attachment #8826014 - Flags: review?(s.kaspari) → review+
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3b8de0c771e4
Convert ZoomedView events to bundle events; r=sebastian
https://hg.mozilla.org/mozilla-central/rev/3b8de0c771e4
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Product: Firefox for Android → GeckoView
Target Milestone: Firefox 53 → mozilla53
You need to log in before you can comment on or make changes to this bug.