Closed Bug 1329061 Opened 5 years ago Closed 5 years ago

audio profile mismatch in rust parser and stagefright

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: ayang, Assigned: ayang)

References

Details

Attachments

(2 files)

Audio profile in rust parser is 2, stagefright is 0 in [1].


[1] http://dl1.streamzilla.jet-stream.nl/preludecd/okt_15_bach_kunst_der_fuge_contrapunctus_I.mov
Blocks: 1302027
Assignee: nobody → ayang
Rust parser is correct in this case. ESDS parsing is ignored due to qt's 'wave' atom doesn't be parsed in stagefright [1].

According to [2], qt's ESDS is inside 'wave' atom, it should be staefright's problem. However, I don't want to mimic this error in rust parser, so I have no choice to fix it in stagefright.


[1] https://dxr.mozilla.org/mozilla-central/rev/b548da4e16f067e5b69349376e37b2db97983cf7/media/libstagefright/frameworks/av/media/libstagefright/MPEG4Extractor.cpp#1651

[2] https://developer.apple.com/library/content/documentation/QuickTime/QTFF/QTFFChap3/qtff3.html#//apple_ref/doc/uid/TP40000939-CH205-75770
Comment on attachment 8824338 [details]
Bug 1329061 - parse ESDS in wave atom container for QT format.

https://reviewboard.mozilla.org/r/102860/#review103868

Can you add gtest with sample file, and is there some standard defining those?
thanks
Attachment #8824338 - Flags: review?(jyavenard) → review+
Comment on attachment 8825651 [details]
Bug 1329061 - add gtest for QT ESDS parsing.

https://reviewboard.mozilla.org/r/103746/#review104736

s/pasring/parsing in commit message
Attachment #8825651 - Flags: review?(jyavenard) → review+
Pushed by ayang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ec90885f5378
parse ESDS in wave atom container for QT format. r=jya
https://hg.mozilla.org/integration/autoland/rev/6bf8894b084d
add gtest for QT ESDS parsing. r=jya
https://hg.mozilla.org/mozilla-central/rev/ec90885f5378
https://hg.mozilla.org/mozilla-central/rev/6bf8894b084d
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.