1329061 - audio profile mismatch in rust parser and stagefright

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Alfredo Yang (:alfredo)]

Audio profile in rust parser is 2, stagefright is 0 in [1].


[1] http://dl1.streamzilla.jet-stream.nl/preludecd/okt_15_bach_kunst_der_fuge_contrapunctus_I.mov

Comment 1

[Alfredo Yang (:alfredo)]

Rust parser is correct in this case. ESDS parsing is ignored due to qt's 'wave' atom doesn't be parsed in stagefright [1].

According to [2], qt's ESDS is inside 'wave' atom, it should be staefright's problem. However, I don't want to mimic this error in rust parser, so I have no choice to fix it in stagefright.


[1] https://dxr.mozilla.org/mozilla-central/rev/b548da4e16f067e5b69349376e37b2db97983cf7/media/libstagefright/frameworks/av/media/libstagefright/MPEG4Extractor.cpp#1651

[2] https://developer.apple.com/library/content/documentation/QuickTime/QTFF/QTFFChap3/qtff3.html#//apple_ref/doc/uid/TP40000939-CH205-75770

Comment 2

[Alfredo Yang (:alfredo)]

Attachment: Bug 1329061 - parse ESDS in wave atom container for QT format.

Review commit: https://reviewboard.mozilla.org/r/102860/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/102860/

Comment 3

[Jean-Yves Avenard [:jya]]

Comment on attachment 8824338 [details]
Bug 1329061 - parse ESDS in wave atom container for QT format.

https://reviewboard.mozilla.org/r/102860/#review103868

Can you add gtest with sample file, and is there some standard defining those?
thanks

Comment 4

[Alfredo Yang (:alfredo)]

Attachment: Bug 1329061 - add gtest for QT ESDS parsing.

Review commit: https://reviewboard.mozilla.org/r/103746/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/103746/

Comment 5

[Jean-Yves Avenard [:jya]]

Comment on attachment 8825651 [details]
Bug 1329061 - add gtest for QT ESDS parsing.

https://reviewboard.mozilla.org/r/103746/#review104736

s/pasring/parsing in commit message

Comment 6

[Alfredo Yang (:alfredo)]

Comment on attachment 8824338 [details]
Bug 1329061 - parse ESDS in wave atom container for QT format.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/102860/diff/1-2/

Comment 7

[Alfredo Yang (:alfredo)]

Comment on attachment 8825651 [details]
Bug 1329061 - add gtest for QT ESDS parsing.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/103746/diff/1-2/

Comment 8

[Alfredo Yang (:alfredo)]

Comment on attachment 8825651 [details]
Bug 1329061 - add gtest for QT ESDS parsing.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/103746/diff/2-3/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec90885f5378
parse ESDS in wave atom container for QT format. r=jya
https://hg.mozilla.org/integration/autoland/rev/6bf8894b084d
add gtest for QT ESDS parsing. r=jya

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ec90885f5378
https://hg.mozilla.org/mozilla-central/rev/6bf8894b084d