1302027 - Moov rust metadata parser to provide detail and stream error location

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Jean-Yves Avenard [:jya]]

Following bug 1299072, we can now provide extensive descriptions back to the JS on why we got a MEDIA_DECODE_ERR.

It would be good to provide details on why an init segment decoding failed.

stagefright has logging telling which box and byte location in the stream caused the failure.

We should provide the same with the rust moov parser.
Can consist of a string like: "Invalid [BLAH] box at 1300 bytes" optionally what was wrong with that box.

Comment 1

[Alfredo Yang (:alfredo)]

Followings are my plan:

1. let the log more readable, for example, change the 4cc number to char.
2. print box name and the remain length in box if parsing is aborted.
3. enable rust log when MOZ_LOG="MP4Metadata:4".

Please let me know if anything is worth to be added.

Comment 2

[Alfredo Yang (:alfredo)]

https://github.com/mozilla/mp4parse-rust/pull/54

Comment 3

[Alfredo Yang (:alfredo)]

Attachment: Bug 1302027 - enable rust log when MP4Metadata prlog is set.

Review commit: https://reviewboard.mozilla.org/r/101760/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/101760/

Comment 4

[Alfredo Yang (:alfredo)]

Comment on attachment 8823189 [details]
Bug 1302027 - enable rust log when MP4Metadata prlog is set.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/101760/diff/1-2/

Comment 5

[Matthew Gregan [:kinetik]]

Comment on attachment 8823189 [details]
Bug 1302027 - enable rust log when MP4Metadata prlog is set.

https://reviewboard.mozilla.org/r/101760/#review105846

Comment 6

[Alfredo Yang (:alfredo)]

Comment on attachment 8823189 [details]
Bug 1302027 - enable rust log when MP4Metadata prlog is set.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/101760/diff/2-3/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d6d0f8b6e78d
enable rust log when MP4Metadata prlog is set. r=kinetik

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d6d0f8b6e78d