1329139 - Disable event recording by default

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P1)

Description

[Georg Fritzsche [:gfritzsche]]

Based on the event storage size discussions and follow-ups, we want to start out with all event recording being disabled by default.
Addons will be able to override this (per category).

We might change that behavior later once we know better which kind of events are critical for our metrics.

We still need to reach out to make people aware of this change.

Comment 1

[Georg Fritzsche [:gfritzsche]]

I already reached out on fhr-dev:
https://mail.mozilla.org/pipermail/fhr-dev/2017-January/001106.html

I also have meetings with the search & shield groups scheduled to sync up on this.

Comment 2

[Georg Fritzsche [:gfritzsche]]

Attachment: Default event recording to disabled

This defaults event recording to disabled and adds a function to selectively enable recording for events in specified categories.

Comment 3

[Alessio Placitelli [:Dexter]]

Comment on attachment 8825742 [details] [diff] [review]
Default event recording to disabled

Review of attachment 8825742 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me, there are just a couple of potential nits in the Events test file.

::: toolkit/components/telemetry/tests/unit/test_TelemetryEvents.js
@@ +35,5 @@
>      }
>    }
>  }
>  
> +add_task(function* test_recording_state() {

nit: do you think it's worth commenting that this should be the first test in the file?

@@ +284,5 @@
>    Assert.equal(events.length, 2, "Should have recorded 2 events.");
>    Assert.equal(events[0][4], value, "Should have recorded the right value.");
>    Assert.equal(events[1][5]["key1"], value, "Should have recorded the right extra value.");
>  });
> +

nit: is this intentional? Odd, my local copy already has a blank line at the end while the one in the repo doesn't seem to have it.

Comment 4

[Georg Fritzsche [:gfritzsche]]

Attachment: Default event recording to disabled

Comment 5

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8825817 [details] [diff] [review]
Default event recording to disabled

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8dd0838d42ff313edc26bfc15cdaf34176380eab

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/78d54111d9be
Default event recording to disabled. r=dexter

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/78d54111d9be