The default bug view has changed. See this FAQ.

ESR - Configure e10s qualification criteria for ESR52

RESOLVED FIXED in Firefox 52

Status

()

Firefox
Extension Compatibility
P2
normal
RESOLVED FIXED
3 months ago
11 days ago

People

(Reporter: shell, Assigned: Felipe)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 54
Points:
---

Firefox Tracking Flags

(firefox52 fixed, firefox53 fixed, firefox54 fixed, firefox-esr5252+ verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

3 months ago
for ESR version - keep Release 50 criteria.  It was determined not to expand  in this population for this ESR.
(Reporter)

Comment 1

3 months ago
[Tracking Requested - why for this release]:

[Tracking Requested - why for this release]:  while we want to expand addons/e10s in general population - the ESR has less ability to correct if there is a need, since they are less likely to get the system add-on update.

should keep ESR on the proven in Release criteria from Release 50 (mpc=true and webextensions), rather than expanding into unmarked add-ons.
tracking-firefox52: --- → ?
Priority: P1 → P2
Summary: ESR 51 keep the same addons/e10s criteria as 50. MPC=true and webextensions → for ESR 52 keep the same addons/e10s criteria as 50. MPC=true and webextensions
tracking-firefox52: ? → +
(Reporter)

Comment 2

2 months ago
Hi Julien,

this particular bug is for system add-on criteria only for ESR 52.  Release system add-on targeting criteria is different.  Sylvestre suggested I need info you to determine how to flag this bug for ESR only check-in.

There is a system add-on in Release - but it has more open criteria for who can run e10s.

Felipe I'm not sure on other targeting restrictions for ESR - outside of no A11y in 52 yet.
Flags: needinfo?(jcristau)
Marking this as blocker for 52 until we have tracking/uplift flags for esr52.

From what I understand, esr52's e10s rollout criteria should also exclude winxp.
tracking-firefox52: + → blocking
Flags: needinfo?(jcristau)
(Reporter)

Comment 4

2 months ago
from meeting today other criteria should be:
No XP.  No A11y.  Add-ons MPC=True and webextensions (blocking lastpass 4.0 from getting e10s in ESR).  

Russian will make determination after it's been in 51 for a few weeks in Release.
Per comment 3, we'll use ESR52 flags to track this bug.
Flags: needinfo?(gchang)
(Assignee)

Comment 6

2 months ago
I'll use this bug to do all the criteria, instead of just add-ons:

- Addons: only mpc=true and webextensions
- XP: no e10s
- No e10s for a11y users
- Russian TBD (but likely yes)
Summary: for ESR 52 keep the same addons/e10s criteria as 50. MPC=true and webextensions → ESR - Configure e10s qualification criteria for ESR52
Moving tracking to new esr52 flags.
status-firefox53: affected → ---
status-firefox-esr52: --- → affected
tracking-firefox52: blocking → ---
tracking-firefox-esr52: --- → 52+
Flags: needinfo?(gchang)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 10

2 months ago
mozreview-review
Comment on attachment 8832992 [details]
Bug 1329752 - Don't enable e10s for XP users on ESR.

https://reviewboard.mozilla.org/r/109224/#review110392
Attachment #8832992 - Flags: review?(jmathies) → review+
Comment on attachment 8832993 [details]
Bug 1329752 - Enable e10s for 100% of eligible users on ESR. Addons eligibility is mpc=true or webextension.

https://reviewboard.mozilla.org/r/109226/#review110638

::: toolkit/mozapps/extensions/internal/E10SAddonsRollout.jsm:922
(Diff revision 1)
> +  "esrB": { addons: [], mpc: true, webextensions: false },
> +  "esrC": { addons: [], mpc: false, webextensions: true },

Good to see you planning ahead. :)
Attachment #8832993 - Flags: review?(mconley) → review+

Comment 12

2 months ago
Pushed by felipc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/96ecba4a2327
Don't enable e10s for XP users on ESR. r=jimm
https://hg.mozilla.org/integration/autoland/rev/5d8c9f8f8d31
Enable e10s for 100% of eligible users on ESR. Addons eligibility is mpc=true or webextension. r=mconley
Backed out for Windows build bustage due to attempted string conversion ins nsAppRunner.cpp:

https://hg.mozilla.org/integration/autoland/rev/3e0339f8c1c9c8744359ed0f1a7b8669d45a9799
https://hg.mozilla.org/integration/autoland/rev/a38ae5c0eb7b9a803c25ce2878286bd36ecba83e

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=5d8c9f8f8d3117c6def1cbd0944e391e7436f4fc
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=74337670&repo=autoland

09:02:02     INFO -  nsAppRunner.cpp
09:02:02     INFO -  c:/builds/moz2_slave/autoland-w32-00000000000000000/build/src/toolkit/xre/nsAppRunner.cpp(4939): error C2440: 'initializing': cannot convert from 'nsAdoptingCString' to 'nsAdoptingString'
09:02:02     INFO -  c:/builds/moz2_slave/autoland-w32-00000000000000000/build/src/toolkit/xre/nsAppRunner.cpp(4939): note: No constructor could take the source type, or constructor overload resolution was ambiguous
09:02:02     INFO -  c:/builds/moz2_slave/autoland-w32-00000000000000000/build/src/config/rules.mk:1015: recipe for target 'nsAppRunner.obj' failed
09:02:02     INFO -  mozmake.EXE[5]: *** [nsAppRunner.obj] Error 2
09:02:02     INFO -  mozmake.EXE[5]: Leaving directory 'c:/builds/moz2_slave/autoland-w32-00000000000000000/build/src/obj-firefox/toolkit/xre'
09:02:02     INFO -  c:/builds/moz2_slave/autoland-w32-00000000000000000/build/src/config/recurse.mk:71: recipe for target 'toolkit/xre/target' failed
09:02:02     INFO -  mozmake.EXE[4]: *** [toolkit/xre/target] Error 2
Flags: needinfo?(felipc)
(Assignee)

Comment 14

2 months ago
s/nsAdoptingString/nsAdoptingCString/
Flags: needinfo?(felipc)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 17

2 months ago
Pushed by felipc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/db8b0dcf5c08
Don't enable e10s for XP users on ESR. r=jimm
https://hg.mozilla.org/integration/autoland/rev/90f7f1e66a1f
Enable e10s for 100% of eligible users on ESR. Addons eligibility is mpc=true or webextension. r=mconley

Comment 18

2 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/db8b0dcf5c08
https://hg.mozilla.org/mozilla-central/rev/90f7f1e66a1f
Status: NEW → RESOLVED
Last Resolved: 2 months ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
(Assignee)

Comment 19

2 months ago
Comment on attachment 8832992 [details]
Bug 1329752 - Don't enable e10s for XP users on ESR.

Approval Request Comment
[Feature/Bug causing the regression]: e10s configuration for ESR 52
[User impact if declined]: e10s will be enabled for WinXP users on ESR, which is not part of the plan
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: yes, when we produce ESR builds (they must be configured as update-channel=esr)
[List of other uplifts needed for the feature/fix]: the other patch in this bug
[Is the change risky?]: no
[Why is the change risky/not risky?]: this code has been used in production to disable e10s on XP for release users since 52. This just extends the criteria from to the ESR channel too.
[String changes made/needed]: none
Attachment #8832992 - Flags: approval-mozilla-beta?
Attachment #8832992 - Flags: approval-mozilla-aurora?
(Assignee)

Comment 20

2 months ago
(In reply to :Felipe Gomes (needinfo me!) from comment #19)
> [Why is the change risky/not risky?]: this code has been used in production
> to disable e10s on XP for release users since 52. This just extends the

I meant 48, of course
(Assignee)

Comment 21

2 months ago
Comment on attachment 8832993 [details]
Bug 1329752 - Enable e10s for 100% of eligible users on ESR. Addons eligibility is mpc=true or webextension.

Approval Request Comment
[Feature/Bug causing the regression]: e10s configuration for ESR 52
[User impact if declined]: e10s won't be rolled out to ESR 52
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: yes, when we produce ESR builds (they must be configured as update-channel=esr)
[List of other uplifts needed for the feature/fix]: the other patch in this bug
[Is the change risky?]: no
[Why is the change risky/not risky?]: this code has been used in production to activate e10s for release users since 48. This just extends the criteria from to the ESR channel too.
[String changes made/needed]: none
Attachment #8832993 - Flags: approval-mozilla-beta?
Attachment #8832993 - Flags: approval-mozilla-aurora?
Comment on attachment 8832993 [details]
Bug 1329752 - Enable e10s for 100% of eligible users on ESR. Addons eligibility is mpc=true or webextension.

e10s criteria for 52esr, take in aurora and beta
Attachment #8832993 - Flags: approval-mozilla-beta?
Attachment #8832993 - Flags: approval-mozilla-beta+
Attachment #8832993 - Flags: approval-mozilla-aurora?
Attachment #8832993 - Flags: approval-mozilla-aurora+
Attachment #8832992 - Flags: approval-mozilla-beta?
Attachment #8832992 - Flags: approval-mozilla-beta+
Attachment #8832992 - Flags: approval-mozilla-aurora?
Attachment #8832992 - Flags: approval-mozilla-aurora+
remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/c3f53a31cc39588c4e12f7a6a7e5790b080ee71f
remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/1419fa7ee013b44501b90487bf8f8873dbaf3727
status-firefox53: --- → fixed

Comment 24

2 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/6f128102982f
https://hg.mozilla.org/releases/mozilla-beta/rev/07fee953e836
status-firefox52: --- → fixed
Flags: qe-verify+

Comment 25

a month ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-esr52/rev/6f128102982f
https://hg.mozilla.org/releases/mozilla-esr52/rev/07fee953e836
status-firefox-esr52: affected → fixed
Verified on latest available version of ESR 52: 20170303022339: 

Windows 10x64, Ubuntu 16.04x64:
- for default profiles <Multiprocess Windows 1/1>.
- when installing add-ons with mpc=false, then <Multiprocess Windows  0/1 (Disabled by add-ons)>

Also, on a Microsoft Surface Pro / Windows 10 that with a11y enabled: <Multiprocess Windows  0/1 Dissabled by accesibility tools>.
status-firefox-esr52: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.