1329802 - WebAuthn unit tests

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, enhancement, P1)

Description

[J.C. Jones [:jcj] (he/they)]

Unit Tests for WebAuthn require Bug 1286312 to land, so moving them from Bug 1309284 into here to track.

Comment 1

[J.C. Jones [:jcj] (he/they)]

Attachment: Bug 1329802 - WebAuthn Unit Tests: Add Unit Tests

This uses the new mochitest "scheme" option from Bug 1286312. This cannot land
until after Bug 1286312 does.

For now, you can test locally by adding
  --setpref dom.securecontext.whitelist=mochi.test
to your command line, such as:

~/hg/mozilla-central/mach mochitest \
  --setpref dom.securecontext.whitelist=mochi.test ./dom/u2f/tests/

Updated:
Review fixes (thanks keeler!)

Review commit: https://reviewboard.mozilla.org/r/103600/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/103600/

Comment 2

[J.C. Jones [:jcj] (he/they)]

keeler - this code is identical to that which was pulled out of Bug 1309284, where this was marked as Part 4. I just changed the commit message.

Comment 3

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Comment on attachment 8825443 [details]
Bug 1329802 - WebAuthn Unit Tests: Add Unit Tests

https://reviewboard.mozilla.org/r/103600/#review104310

Ok - looks good to me.

::: dom/u2f/tests/test_webauthn_sameorigin.html:84
(Diff revision 1)
> +    .then(arrivingHereIsGood)
> +    .catch(arrivingHereIsBad),
> +
> +    // Test this origin with optional fields
> +    authn.makeCredential(acct, [param], chall,
> +                         {rpId: "user:pass@"+document.origin+":8888"})

nit: for these, I would either put spaces between the '+' operators or use template literals

::: dom/u2f/tests/u2futil.js:145
(Diff revision 1)
> +  }
> +
> +  u2fRegObj.keyHandle = bytesToBase64UrlSafe(u2fRegObj.keyHandleBytes);
> +
> +  return importPublicKey(u2fRegObj.publicKeyBytes)
> +  .then(function(keyObj){

nit: space before '{'

Comment 4

[J.C. Jones [:jcj] (he/they)]

Comment on attachment 8825443 [details]
Bug 1329802 - WebAuthn Unit Tests: Add Unit Tests

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/103600/diff/1-2/

Comment 5

[J.C. Jones [:jcj] (he/they)]

Comment on attachment 8825443 [details]
Bug 1329802 - WebAuthn Unit Tests: Add Unit Tests

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/103600/diff/2-3/

Comment 6

[J.C. Jones [:jcj] (he/they)]

Comment on attachment 8825443 [details]
Bug 1329802 - WebAuthn Unit Tests: Add Unit Tests

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/103600/diff/3-4/

Comment 7

[J.C. Jones [:jcj] (he/they)]

Try run looks good, after consulting in #releng. Note that the mochitest-valgrind oranges are all tryserver bugs, they are not intended to be shown.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8f0747d4d61af2f1ac6dc18408ff103b0e193a3a

Marking checkin-needed.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea3744df8af6
WebAuthn Unit Tests: Add Unit Tests r=keeler

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ea3744df8af6