1329808 - Enable V4 completions

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect, P2)

Comment 1

[Thomas Nguyen (:tnguyen)]

Francois, it seems this bug should be set to M5. I am sorry I missed this bug :(.
Though I see there's still a bug dependency here bug 1311935, do you want to land enabling v4 completion now?
Just change the empty getHashUrl in preference list to
pref("browser.safebrowsing.provider.google4.gethashURL", "https://safebrowsing.googleapis.com/v4/fullHashes:find?$ct=application/x-protobuf&key=%GOOGLE_API_KEY%");

Comment 2

[François Marier [:francois]]

(In reply to Thomas Nguyen[:tnguyen] ni plz from comment #1)
> Francois, it seems this bug should be set to M5. I am sorry I missed this
> bug :(.

This is almost a meta bug, the real work in happening in the dependencies.

> Though I see there's still a bug dependency here bug 1311935, do you want to
> land enabling v4 completion now?

We shouldn't enable completions before we have caching otherwise it will generate too much traffic to the Google servers.

Comment 3

[Thomas Nguyen (:tnguyen)]

thanks francois for clarifying :)

Comment 4

[Thomas Nguyen (:tnguyen)]

Attachment: Bug 1329808 - Enable V4 completions in Nightly but ignore the result

Review commit: https://reviewboard.mozilla.org/r/122250/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/122250/

Comment 5

[François Marier [:francois]]

Comment on attachment 8849467 [details]
Bug 1329808 - Enable V4 completions in Nightly but ignore the result

https://reviewboard.mozilla.org/r/122250/#review124462

Looks good, but please update the commit message before landing.

::: commit-message-5fe5d:1
(Diff revision 1)
> +Bug 1329808 - Enable V4 completions but ignore result

The commit message should specify that this is Nightly-only:

    Bug 1329808 - Enable V4 completions in Nightly but ignore the result

Comment 6

[Thomas Nguyen (:tnguyen)]

Comment on attachment 8849467 [details]
Bug 1329808 - Enable V4 completions in Nightly but ignore the result

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/122250/diff/1-2/

Comment 7

[Thomas Nguyen (:tnguyen)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5d073b1917008ca5a5fc96705263efec401e9a6b

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/10eb56897811
Enable V4 completions in Nightly but ignore the result r=francois

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/10eb56897811