Closed
Bug 1329817
Opened 8 years ago
Closed 8 years ago
Enable V4 lookups
Categories
(Toolkit :: Safe Browsing, defect, P2)
Toolkit
Safe Browsing
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: francois, Assigned: dimi)
References
Details
(Whiteboard: #sbv4-m6)
Attachments
(1 file)
While V4 updates are enabled by bug 1305486, URLs are not looked up in the V4 lists yet.
|
Reporter | |
Updated•8 years ago
|
Priority: -- → P2
|
|
Reporter | |
Updated•8 years ago
|
Blocks: safebrowsingv4
|
|
Reporter | |
Updated•8 years ago
|
Whiteboard: #sbv4-m6
|
||
Updated•8 years ago
|
Assignee: nobody → tnguyen
|
|
Reporter | |
Updated•8 years ago
|
Status: NEW → ASSIGNED
|
Assignee | |
Updated•8 years ago
|
Assignee: tnguyen → dlee
| Comment hidden (mozreview-request) |
|
|
Reporter | |
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8858692 [details]
Bug 1329817 - Enable V4 lookups.
https://reviewboard.mozilla.org/r/130700/#review133488
I don't think we need the `#ifdef NIGHTLY` here because we already have completions disabled in NIGHTLY: https://searchfox.org/mozilla-central/rev/a7334b2896ed720fba25800e11e24952e6037d77/modules/libpref/init/all.js#5254-5258
Attachment #8858692 -
Flags: review?(francois) → review-
|
|
Reporter | |
Comment 3•8 years ago
|
||
(In reply to François Marier [:francois] from comment #2)
> Comment on attachment 8858692 [details]
> Bug 1329817 - Enable V4 lookups.
>
> https://reviewboard.mozilla.org/r/130700/#review133488
>
> I don't think we need the `#ifdef NIGHTLY` here because we already have
> completions disabled in NIGHTLY:
> https://searchfox.org/mozilla-central/rev/
> a7334b2896ed720fba25800e11e24952e6037d77/modules/libpref/init/all.js#5254-
> 5258
In fact, maybe we should just remove that pref entirely (essentially backing out bug 1331534) since we now have working completions and caching.
|
|
Reporter | |
Comment 4•8 years ago
|
||
Nevermind my previous comments, I forgot that we need to have this around so that we can enable V4 without honoring it on Beta (to get better telemetry).
|
|
Reporter | |
Comment 5•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8858692 [details]
Bug 1329817 - Enable V4 lookups.
https://reviewboard.mozilla.org/r/130700/#review133548
Attachment #8858692 -
Flags: review- → review+
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bd3e8fdd819c
Enable V4 lookups. r=francois
Keywords: checkin-needed
|
||
Comment 7•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•