1329833 - [wdspec] Add tests for parsing of actions messages

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect, P1)

Description

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Similar in spirit to https://dxr.mozilla.org/mozilla-central/rev/2977ca1224525680cbfb5c3ce3018818b6dfd8f2/testing/marionette/test_action.js

Comment 1

[Andreas Tolfsen ❲:ato❳]

maja_zf: Has this been done now?  I remember reviewing WPT action tests.

Comment 2

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

This bug is about tests that check the format of the json payload of the command, invalid requests, etc. 

There are xpcshell tests like that in test_action.js, but none in wpt. The wpt actions tests you reviewed mostly check the events synthesized by commands.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Bringing this up for triage given that for element interaction in BiDi we want to re-use the action implementation from classic (bug 1792090) and would require such tests. We could certainly add BiDi tests first on a different bug and come back to that one afterward.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

We will pick this bug up after bug 1792090 has been landed and will create tests for BiDi as well as classic given that the assertions won't be different. Given that our focus is on BiDi lets move it to its component.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Actually other implementations might not share the same code and as such it will be better to have the same tests for both protocols. As such lets move this one back to Marionette and create a new WebDriver BiDi specific bug.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1329833 - [wdspec] Add tests for parsing of actions messages.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bde95b6dffb0
[wdspec] Add tests for parsing of actions messages. r=webdriver-reviewers,jdescottes

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/40837 for changes under testing/web-platform/tests

Comment 9

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/bde95b6dffb0

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1329833 - [wdspec] Extend timeout for classic/perform_actions/invalid.py.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b5f7e8f33e3a
[wdspec] Extend timeout for classic/perform_actions/invalid.py.

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Comment 14

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/b5f7e8f33e3a

Comment 15

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by jgraham