remove trailing newURI null parameters in comm-central

RESOLVED FIXED in Thunderbird 53.0

Status

defect
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: florian, Assigned: florian)

Tracking

unspecified
Thunderbird 53.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
I figured I would run on comm-central the scripts I wrote for bug 1329182.
(Assignee)

Comment 1

2 years ago
Posted patch PatchSplinter Review
This patch is fully script-generated, no hand editing at all. I'm not sure how many reviews we need for this. For the m-c changes in bug 1329182 I got reviews only from a browser & toolkit peer.
Attachment #8825376 - Flags: review?(philipp)
Attachment #8825376 - Flags: review?(aleth)
(Assignee)

Updated

2 years ago
Assignee: nobody → florian
Status: NEW → ASSIGNED

Updated

2 years ago
Attachment #8825376 - Flags: review?(philip.chee)
Attachment #8825376 - Flags: review?(mkmelin+mozilla)

Comment 2

2 years ago
Comment on attachment 8825376 [details] [diff] [review]
Patch

Review of attachment 8825376 [details] [diff] [review]:
-----------------------------------------------------------------

I looked at chat/, im/, and ldap/.
Attachment #8825376 - Flags: review?(aleth) → review+
Comment on attachment 8825376 [details] [diff] [review]
Patch

Script seems to work well, I've checked a few cases. I'm going to r+ this for all of c-c to save some reviewer time. r=philipp
Attachment #8825376 - Flags: review?(philipp)
Attachment #8825376 - Flags: review?(philip.chee)
Attachment #8825376 - Flags: review?(mkmelin+mozilla)
Attachment #8825376 - Flags: review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 4

2 years ago
https://hg.mozilla.org/comm-central/rev/48fcd36a39e793b2c92a76a0128c936762757b5e
Pushed with changes to suite/ as well, I hope they don't hate us now ;-)

I hope those scripts worked well, since there were some more demanding cases of multi-line edits, for example:
-                       btoa(synthMessage.toMessageString()),
-                       null, null);
+                       btoa(synthMessage.toMessageString()));
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 53.0

Comment 5

2 years ago
(In reply to Jorg K (GMT+1) from comment #4)
> I hope those scripts worked well, ...
Apparently so ;-) - Bug 1329182 comment #7.
You need to log in before you can comment on or make changes to this bug.