133011 - Safer key mapping for show/hide tabs

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[xyzzy]

The problem is that it it too easy to have both a browser and chat window open,
forget which one has focus, and try to hit Ctrl+T in an attempt to open a new
tab in the browser window.  If the ChatZilla window is open, this hides the
tabs.  The first time I did this, I thought I had found a bug.

Because this change makes navigation difficult, and is not easily discoverable,
it will make life difficult for a lot of end users.  I would like to see this
key binding changed to make it less prone to this kind of error, but anything
that would make the change more obvious would also help, like a message in the
current chat view.

Comment 1

[Samuel Sieb]

Why don't we just remove this shortcut key entirely?  It's not something that
will be used frequently, so using the menu should be sufficient.

Comment 2

[xyzzy]

Agreed.

Comment 3

[Koike Kazuhiko]

Attachment: patch v1

Removed the shortcut keys in [View]-[Show/Hide].

Comment 4

[Robert Ginda]

Comment on attachment 118620 [details] [diff] [review]
patch v1

I use ctrl-L a few times a month.  I normally run chatzilla without the
userlist, but need it every once in a while.  I imagine there might be others
who do the same with the header.

The status bar and tab strip are probably less likely to be toggled frequently,
I suppose I wouldn't have a problem with removing key bindings for those two.

Comment 5

[Koike Kazuhiko]

Attachment: patch v2

Comment 6

[Robert Ginda]

Comment on attachment 118705 [details] [diff] [review]
patch v2

r=rginda

Comment 7

[Samuel Sieb]

checked in

Comment 8

[James Ross]

Argh! I use the show/hide tabs shortcut all the time! And the show/hide
statusbar one is just useful, though I don't use it as much.

Comment 9

[Robert Ginda]

maybe we should put these back in under different names.  The only one that
conflicted was accel-T, right?

Comment 10

[James Ross]

ChatZilla 0.9.15 (and all 0.9.x) uses Ctrl-Shift with T (tabs), L (user list), H
(heading) and S (statusbar). I don't think these conflict with anything, and if
so, can we close this bug?

Comment 11

[Robert Ginda]

Any bugs that are fixed in 0.9.x should be marked as dependent on bug 210744. 
We can mark them as fixed when the branch lands.

Comment 12

[Robert Ginda]

The chatzilla 0.9.x branch has landed on the trunk and should be available in
tomorrow's nightly build.  If you believe this bug has not actually been fixed,
please repoen it.