210744 - make chatzilla better

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Robert Ginda]

This is a tracker bug for the newly created CHATZILLA_COMMANDS_YOU branch.

This branch is intended to give chatzilla a much needed overhaul.  I'll be
merging in the command, message (i18n), menu, and pref management code from
Venkman initially.  The view code will probably have to wait, as this is going
to be alot of work as it is.  This will lay some ground work for the view code,
at least.

Comment 1

[Robert Ginda]

Attachment: initial diff

Here's the current diff.  There are a few notes about the venkman manager code
at http://www.hacksrus.com/~ginda/venkman/techtalk/.

So far:
 * all commands have been converted to venkman-style commands.	they're all
defined in commands.js.  parameters are now specified in the .properties file. 
See the "Defining a command" and "Dispatching a command" pages of the notes.

 * Introduced venkman message manager.	This thing enumerates over a
.properties file, creating variables based on the name of each message it
finds.	if the message has no replacements (%S), the variable will contain the
message text, and never needs to be looked up again.  If the message has
replacements, then the variable will contain the message name, for use with
getMsg().  See the "Localization utilities" section of the notes.

 * started migrating preferences from reafprefs.js into prefs.js.  prefs.js
uses the new pref-manager.js to make things easier.  prefs that have been
migrated are commented out of readprefs.js.  readprefs.js will go away before
this branch lands.  See the "Preference management" section of the notes.

 * added prefs to network objects, set up net-specific prefs for nick, etc.

 * reworked init code.	I took a shot a breaking up the initialization code, it
should be more managable now.

 * changed server list from an array of Objects, to and array of CIRCServers. 
We used to keep the server list as an array of objects that happened to have
host, post, and passowrd properties.  Now they're full-fledged CIRCServer
objects.

 * lots of chatzilla.properties changes.  Lissyx will love this one.

 * much formatting cleanup, removed space-before-parameters: "foo ()" ->
"foo()", removal of vertical whitespace, etc.

I havn't even started hooking up the venkman menu manager.

The basics work, I can attach, join, disconnect, ping out and autoreconnect,
etc., but there are many bugs left to fix.

Comment 2

[Robert Ginda]

I finally posted the 0.9.0 xpi to http://hacksrus.com/~ginda/chatzilla.  It's
all checked in to the branch as well.  There will probably be a number of
regressions in this release.

Check out the new file menus.js for the definitions of the main menu and the two
context menus.  getMessagesContext and getUserlistContext in static.js are 
context getters for the context menus.

Comment 3

[James Ross]

Attachment: A few minotr fixes

This is a diff of the chatzilla.jar layout, since CVS still seems to have
0.8.34 in it.

It simply fixes two typos, and one JS error.

Comment 4

[James Ross]

Attachment: A few more minor fixes

This patch fixes, in order:

- /open-at-startup reported things inverted, a missing \ in regexp for
PrefManager.prototype.stringToArray.
- makes userlist/message context menus more consistent with each other (a
semi-personal thing, it just bugged me :) ).
- updated Startup pref page to escape/unescape when accessing list prefs (as
per Pref Manager code).
- fixes bug where network/command list is not on *client* tab (bug 206177) by
init-ing everything else before opening initial URLs.
- adds an unescape call into old code for INITIAL_SCRIPTS, to make it
compatible with list prefs, as used now by the Startup pref page.

Comment 5

[James Ross]

Also found that other people changing nickname doesn't work - "RoboAway is now
known as (null)" - and the userlist doesn't update, but the internal list seems
to be ok. Can't work out why, yet.

Comment 6

[Robert Ginda]

silver, the 0.9.x code lives on a cvs branch called CHATZILLA_COMMANDS_YOU. 
type `cvs up -r CHATZILLA_COMMANDS_YOU` from extensions/irc to change to this
branch.

Comment 7

[James Ross]

Ok, thanks. Now if only there was some *easy* way to move files between the .JAR
layout and the CVS layout... ;)

Comment 8

[Jan Eri]

Some immediate comments to 0.9.1, originally posted at #chatzilla:

- does not respect the servers/channels to join at startup, nor the CSS
 -my server says "Mode #slektsprat +o JanEri by slektprat", but the OP indicator
does not turn green. Actually the nickname-list seems not to be updated at all.
Not the nicknames when they change, and not the color when OP-status change.
- the buttons to start browser, email etc in the lower left corner is missing
- I get messages like "Sam|away is now known as (null)"
- accented chars seems broken, I get complaints that Norwegian chars are garbled

JanE

Comment 9

[Jan Eri]

Som more comments:

The "File" and "View" menus are missing. Small invisible buttons are present
where they should have been, but no action when clicked.

I did a quick test of most of the commands in the help text, results below:

[USAGE]	away
[HELP]	If <reason> is specified, sets you away with that message. Used without
<reason>, you are marked back as no longer being away.

Even with <reason> given the response is "You are no longer marked as being away"

[USAGE]	channel-charset [<charset>]
[HELP]	Sets the character encoding mode to <charset>, or displays the current
character encoding mode if <charset> is not provided.

Response is "Internal error dispatching command ?channel-charset?."

[USAGE]	charset [<charset>]
[HELP]	Sets the character encoding mode to <charset>, or displays the current
character encoding mode if <charset> is not provided.

Response to /charset is "Character encoding mode is now ?%S?."

[USAGE]	eval <expression>
[HELP]	Evaluates <expression> as JavaScript code. Not for the faint of heart.

This command is listed twice in the help-text

[USAGE]	hide-view [<view>]
[HELP]	Drop the current view's icon from the tab strip, but save its contents.
The icon will reappear the next time there is activity on the view.

No effect at all?

[USAGE]	open-at-startup [<toggle>]
[HELP]	Used to add the current view to the list of views that will be
automatically opened at startup. If <toggle> is not provided, the status of the
current view will be displayed. <toggle> can be one of: yes, on, true, 1, no,
off, false, 0, or toggle, to toggle the current state.

"Yes" does not stick

[USAGE]	pref [<pref-name> [<pref-value> [<delete-pref>]]]
[HELP]	Sets the value of the preference named <pref-name> to the value of
<pref-value>. If <pref-value> is not provided, the current value of <pref-name>
will be displayed. If both <pref-name> and <pref-value> are omitted, all
preferences will be displayed. If <delete-pref> is provided and is |true|, |on|,
|yes|, or |1|, or if <pref-name> starts with a minus ('-') character, then the
preference will revert back to its default value.

With /pref , the status for logging is incorrect. Maybe others as well.

[USAGE]	deop <nickname> [<...>]
[HELP]	Removes operator status from <nickname> on current channel. Requires
operator status.

response "Internal error dispatching command ?deop?."

Comment 10

[Robert Ginda]

Comment on attachment 127696 [details] [diff] [review]
A few minotr fixes

Thanks for the fixes, these are rolled in as of 0.9.2

Comment 11

[Robert Ginda]

Comment on attachment 127733 [details] [diff] [review]
A few more minor fixes

Thanks for the fixes, these are rolled in as of 0.9.2

Comment 12

[James Ross]

Jan, the menus not being there is because one of your auto-load scripts had an
error - I got it initially, but once the errors in the scripts were fixed, the
menus were there fine (we probably ought to try/catch the errors better for
scripts?).

I also noticed the CSS/motif was lost, but setting in the pref page does put it
back... though it doesn't seem to work for the /Collapse/ option.

Comment 13

[James Ross]

Small note about the 'open link' stuff:

Right-clicking a link here just 'clicks' it - no context menu at all! (and it
overwrites my current webpage)

I could find no way to open in a new /tab/ - click was replace, Ctrl-click was
new window, and Shift-click/Alt-click (the only options remaining) both did the
same as a normal click (i.e. replace).

Comment 14

[Robert Ginda]

that's because on windows (and, it seems, only on windows), the onclick event
fires for right clicks.  In 0.9.4 I added a button-number test in the onclick
handler, so this should work on all platforms now.

Comment 15

[James Ross]

(personally I see no reason onclick show /not/ fire for a non-left-click, but
that's just my view)

It's still lacking any way to open in a new tab without using the context menu,
though. According to /pref, it's 'metaClick', but I can't find any way to
actually trigger it (I guess mothing on Windows is mapped by Mozilla to the key
modifyer 'meta').

Comment 16

[James Ross]

Attachment: diff -u of CVS tree extensions\irc

Fixes the following commands as previously mentioned in this bug:

/charset, /channel-charset, /hide-view and /away.

Also a small case of tabs in the source has been fixed. :)

Comment 17

[Robert Ginda]

Comment on attachment 127847 [details] [diff] [review]
diff -u of CVS tree extensions\irc

rolled into 0.9.5, thanks again

Comment 18

[Felix Miata]

Does nicklist failure to refresh automatically for such changes as op status and
nick changes need its own bug?

Comment 19

[Robert Ginda]

no, it doesn't.  the nick list is likely to change drastically, RSN.

Comment 20

[Jan Eri]

I had one channel that always opened with CZ as specified in prefs/startup, but
it is not checked at "Open this channel at startup". It is confirmed that this
is because the casing of the url in the header was different from the url in the
startup list.

Casing should be ignored, shouldn't it?

Comment 21

[Robert Ginda]

Attachment: latest diff, part 1

branch as of 0.9.23, merged with the trunk to make 0.9.24

Comment 22

[Robert Ginda]

Attachment: latest diff, part 2

diff was too big for bugzilla to take as a single attachment.

Comment 23

[Robert Ginda]

I'd like to land the CHATZILLA_COMMANDS_YOU branch for 1.5b, for the extra
testing.  There are a ton of good fixes in here, along with a big version number
change.

Comment 24

[James Ross]

Attachment: Quick fix for the /log command

This fixes the /log command, which seems totally broken in 0.9.27, and updates
the help text to make it clearer what to do.

Comment 25

[Asa Dotzler [:asa]]

Comment on attachment 129890 [details] [diff] [review]
latest diff, part 1

a=asa (on behalf of drivers) for checkin to 1.5beta

Comment 26

[Robert Ginda]

checked in!

Comment 27

[Robert Ginda]

Comment on attachment 129890 [details] [diff] [review]
latest diff, part 1

it would be nice to get this on 1.4x too

Comment 28

[Mike Kaply [:mkaply]]

Comment on attachment 129890 [details] [diff] [review]
latest diff, part 1

a=mkaply for 1.4.1 (there are no translation changes)

Comment 29

[Robert Ginda]

checked in to the 1.4 branch.

Comment 30

[Mike Kaply [:mkaply]]

Unfortunately I had to back this out of the 1.4 branch because of l10n issues.

IF we decide to let 1.4.2 have l10n changes, we'll put it back.