Closed Bug 1330249 Opened 7 years ago Closed 7 years ago

IonBuilder::build() is too slow when loading GSlides

Categories

(Core :: JavaScript Engine: JIT, defect, P1)

Product:
Core
Component:
JavaScript Engine: JIT
Type:
defect

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1346191
Project Flags:
Performance Impact low

People

(Reporter: ehsan.akhgari, Unassigned)

References

Details

When profiling bug 1326346, I noticed IonBuilder::build() takes about 745ms out of 9 seconds.

See https://clptr.io/2jCcNLd

Sean can you take a look please?
Flags: needinfo?(sstangl)
Sean: ping?
Whiteboard: [qf:p3]
I can't reproduce this locally (Linux x64). On my system, it looks like this: https://perfht.ml/2nxp6cv. It also doesn't take 9 seconds to load the slides.

Perf shows 75% of time spent in the Compositor.

Page was at this address: https://docs.google.com/presentation/d/1VvEZ9DSIlbjXXXY01wAccMdaF2q9wA1Zx21-nuH3KQc/edit#slide=id.g1cded15646_0_0
Flags: needinfo?(sstangl)
It's possible my patch for bug 1346191 fixed this.
@Ehsan: can you remeasure and see if this is still an issue?
Flags: needinfo?(ehsan)
Priority: -- → P1
New profile shows 237ms in this function now, much better! https://perfht.ml/2oT3vxd

Thanks!
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(ehsan)
Resolution: --- → DUPLICATE
Performance Impact: --- → P3
Whiteboard: [qf:p3]
You need to log in before you can comment on or make changes to this bug.