1330282 - Intermittent test_prefs.py TestPreferences.test_get_pref_value_type | AssertionError: None != 'chrome://branding/locale/browserconfig.properties'

Status: RESOLVED FIXED

(Testing :: Marionette Client and Harness, defect)

Description

[Treeherder Bug Filer]

Filed by: hskupin [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=67954589&repo=autoland

https://queue.taskcluster.net/v1/task/Np_5XgqSReC-LiUYeuFtPw/runs/0/artifacts/public/logs/live_backing.log

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Instead of the current properties file which only exists for Firefox we can use the preference "browser.menu.showCharacterEncoding". This is present in both applications and also references the same properties file.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1330282 - Fix test_get_pref_value_type() for Fennec.

The preference "browser.startup.homepage" is only used for Firefox, so the
test fails for Fennec. By using "browser.menu.showCharacterEncoding" which
is used in both Firefox and Fennec the test is passing.

Review commit: https://reviewboard.mozilla.org/r/103820/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/103820/

Comment 3

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8825745 [details]
Bug 1330282 - Fix test_get_pref_value_type() for Fennec.

https://reviewboard.mozilla.org/r/103820/#review104572

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e5f5f3138b8
Fix test_get_pref_value_type() for Fennec. r=maja_zf

Comment 5

[Guilherme Lima]

Patch landed few hours ago https://hg.mozilla.org/mozilla-central/rev/2e5f5f3138b8

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Please uplift this test-only patch to aurora. Thanks.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/58c9ae2f0faf

Comment 8

[BMO Automation]

Moving bug to Testing::Marionette Client and Harness component per bug 1815831.