1330318 - Setting b=TIAS caps us at 2kbps

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P1)

Description

[Randell Jesup [:jesup] (needinfo me)]

+++ This bug was initially created as a clone of Bug #1320101 +++

In bug 1320101 it was noted that mDroppedFrames is increasing at a crazy rate.

It appears a set of parens were lost in the conversion from CodecStatistics.cpp to the Call interface in the 49 update

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Fix droppedFrames statistic in webrtc, and improve debugs

haven't tried it yet...  compare to CodecStatistics.cpp's (old) impl, still in the tree though not used now

Comment 2

[Andreas Pehrson [:pehrsons] (away until Aug 26)]

Comment on attachment 8825821 [details] [diff] [review]
Fix droppedFrames statistic in webrtc, and improve debugs

Review of attachment 8825821 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/webrtc/signaling/src/media-conduit/VideoConduit.cpp
@@ +123,5 @@
>    StreamStatistics::Update(aStats.encode_frame_rate, aStats.media_bitrate_bps);
>    if (!aStats.substreams.empty()) {
>      const webrtc::FrameCounts& fc =
>        aStats.substreams.begin()->second.frame_counts;
> +    CSFLogVerbose(logTag, "%s: framerate: %u, bitrate: %u, dropped frames delta: %u", __FUNCTION__,

Line looks a bit long.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ac80b556e979
Fix droppedFrames statistic in webrtc, and improve debugs r=pehrsons

Comment 4

[Wes Kocher (:KWierso)]

https://hg.mozilla.org/mozilla-central/rev/ac80b556e979