add BUG_COMPONENT to devtools/* files

RESOLVED FIXED in Firefox 53

Status

enhancement
P3
normal
RESOLVED FIXED
3 years ago
Last year

People

(Reporter: jmaher, Assigned: jmaher)

Tracking

53 Branch
Firefox 53
Dependency tree / graph

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

we have cool features in mach to get file-info about a specific file in tree:
$ ./mach file-info bugzilla-component devtools/**
Firefox :: Developer Tools
  devtools/bootstrap.js
  devtools/chrome.manifest
  devtools/client
  devtools/docs
  devtools/install.rdf
  devtools/moz.build
  devtools/server
  devtools/templates.mozbuild
Firefox :: Developer Tools: Shared Components
  devtools/shared


In this case I have edited moz.build files to make a good stab at finding the appropriate components for each file.  Ideally all source/test files would be easy to find the proper bugzilla component.
:jryans, feel free to assign to someone else or ask for additional review.  This is just changes to moz.build files and I will follow up in the future on specific test manifests to make sure all of that makes sense- the more we can get right now the better :)
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #8825830 - Flags: review?(jryans)
Comment on attachment 8825830 [details] [diff] [review]
add BUG_COMPONENT to devtools/*

Review of attachment 8825830 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for doing this, looks like we're getting close!

::: devtools/client/responsivedesign/moz.build
@@ +10,5 @@
>      'responsivedesign.jsm',
>  )
> +
> +with Files('**'):
> +    BUG_COMPONENT = ('Firefox', 'Developer Tools: Responsive Design Mode')

It would be good to tag devtools/client/responsive.html with this value too.

::: devtools/client/shared/moz.build
@@ +54,5 @@
>      'zoom-keys.js',
>  )
> +
> +with Files('**'):
> +    BUG_COMPONENT = ('Firefox', 'Developer Tools: Shared Components')

The Shared Components bug component is somewhat nebulous...  I believe it only covers devtools/client/shared/components.  The rest should just be the main DevTools component.

::: devtools/moz.build
@@ +39,5 @@
> +with Files('docs/debugger-api.md'):
> +    BUG_COMPONENT = ('Firefox', 'Developer Tools: Debugger')
> +
> +with Files('docs/http-inspector.md'):
> +    BUG_COMPONENT = ('Firefox', 'Developer Tools: Inspector')

This should be Console.

@@ +45,5 @@
> +with Files('docs/inspector-panel.md'):
> +    BUG_COMPONENT = ('Firefox', 'Developer Tools: Inspector')
> +
> +with Files('client/**'):
> +    BUG_COMPONENT = ('Firefox', 'Developer Tools')

I think these would make more sense in the devtools/client moz.build.

@@ +48,5 @@
> +with Files('client/**'):
> +    BUG_COMPONENT = ('Firefox', 'Developer Tools')
> +
> +with Files('client/commandline/**'):
> +    BUG_COMPONENT = ('Firefox', 'Developer Tools')

Aren't these redundant with the previous line for all of client?

@@ +60,5 @@
> +with Files('client/projecteditor/**'):
> +    BUG_COMPONENT = ('Firefox', 'Developer Tools')
> +
> +with Files('client/responsive.html'):
> +    BUG_COMPONENT = ('Firefox', 'Developer Tools: Responsive Design Mode')

This can move to the moz.build inside that directory.

::: devtools/server/moz.build
@@ +35,1 @@
>      'css-logic.js',

Each tool does have one or more files under devtools/server/actors, but I am not sure it's worth going to that level of detail...?

@@ +44,5 @@
> +with Files('**'):
> +    BUG_COMPONENT = ('Firefox', 'Developer Tools')
> +
> +with Files('*Inspector*'):
> +    BUG_COMPONENT = ('Firefox', 'Developer Tools: Inspector')

I don't think this one is correct, probably best to remove.

::: devtools/shared/moz.build
@@ +66,5 @@
>      'ThreadSafeDevToolsUtils.js',
>  )
> +
> +with Files('**'):
> +    BUG_COMPONENT = ('Firefox', 'Developer Tools: Shared Components')

This is just main DevTools.
Attachment #8825830 - Flags: review?(jryans) → review-
Thanks for the quick review- I had to start somewhere with this and got a good start.  I can address all of these issues.  For reference, there is some redundancy- if the review didn't spur any other components to address, then I can make the client/** all map to the general "developer tools" unless otherwise specified- no need to specify other directories.

Let me take a stab at the server/actors/ directory- if it looks too hairy, then I will abort and keep it generic for now.
I have addressed all the comments- feel free to r- if you see other things to add/change, or would desire using different moz.build files.
Attachment #8825830 - Attachment is obsolete: true
Attachment #8825920 - Flags: review?(jryans)
Severity: normal → enhancement
Priority: -- → P3
forgot to cleanup a comment in devtools/client/moz.build
Attachment #8825920 - Attachment is obsolete: true
Attachment #8825920 - Flags: review?(jryans)
Attachment #8825936 - Flags: review?(jryans)
Comment on attachment 8825936 [details] [diff] [review]
add BUG_COMPONENT to devtools/* (v3.0)

Review of attachment 8825936 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, I think that's pretty good for a first pass!

::: devtools/server/actors/moz.build
@@ +80,5 @@
> +with Files('css-properties.js'):
> +    BUG_COMPONENT = ('Firefox', 'Developer Tools: CSS Rules Inspector')
> +
> +with Files('csscoverage.js'):
> +    BUG_COMPONENT = ('Firefox', 'Developer Tools: CSS Rules Inspector')

DT: Graphic Commandline and Toolbar

@@ +89,5 @@
> +with Files('memory.js'):
> +    BUG_COMPONENT = ('Firefox', 'Developer Tools: Memory')
> +
> +with Files('monitor.js'):
> +    BUG_COMPONENT = ('Firefox', 'Developer Tools: Netmonitor')

Just the main Developer Tools.

@@ +98,5 @@
> +with Files('profiler.js'):
> +    BUG_COMPONENT = ('Firefox', 'Developer Tools: Performance Tools (Profiler/Timeline)')
> +
> +with Files('source.js'):
> +    BUG_COMPONENT = ('Firefox', 'Developer Tools: Source Editor')

Debugger
Attachment #8825936 - Flags: review?(jryans) → review+
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/50e914c1f164
add BUG_COMPONENT to devtools/* files. r=jryans
https://hg.mozilla.org/mozilla-central/rev/50e914c1f164
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.