1328351 - [meta] - tracking bug for getting BUG_COMPONENT specified for all files in the tree

Status: RESOLVED FIXED

(Testing :: General, defect)

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

looking at third_party/ this is rust libraries vendored in, there is no real component here.
looking at stylo/ there are a lot of changes going in (including test files), but there are no bugs associated with the changes, I am looking to see what to do about stylo/.
we also have the b2g/ directory, I am not sure I will get clear ownership there.

Ignoring those 3 and what is filed, I still have bugs to file for:
browser
db
docshell
mfbt
mobile
modules
nsprpub
testing (last part of web-platform/tests/)
toolkit
widget

I would expect getting that list cut in half in the next 2 weeks.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

what work remains is:
browser (probably in 2 or 3 parts)
mfbt
nsprpub
testing (last part of web-platform/tests/)
toolkit (partially done)
widget (probably in 2 parts)

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

I now have:
UNKNOWN
  mfbt
  nsprpub
  servo
  testing (awsy, loose files, web-platform - web-platform is big, so leaving in the unknown bucket)

mostly done, need polish, new files:
  mobile
  services
  third_party
  toolkit
  xpfe

Comment 4

[Gregory Szorc [:gps]]

PSA: you can now use '**' as the file pattern for `mach file-info` and you won't get errors from invalid moz.build files that are part of moz.build's test harness. Now, it will take a long time to run. But at least it won't error.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: annotate many remaining files in testing/ and toolkit/ with BUG_COMPONENTS

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: annotate many remaining files in testing/ and toolkit/ with BUG_COMPONENTS

forgot one file, this should be good to go

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: annotate many remaining files in testing/ and toolkit/ with BUG_COMPONENTS

Ted, this should be a final patch, I would appreciate a review or redirect to someone else.

Comment 9

[Gregory Szorc [:gps]]

Comment on attachment 8907346 [details] [diff] [review]
annotate many remaining files in testing/ and toolkit/ with BUG_COMPONENTS

Review of attachment 8907346 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/moz.build
@@ +2,5 @@
> +    BUG_COMPONENT = ("Testing", "AWSY")
> +
> +with Files("config/**"):
> +    BUG_COMPONENT = ("Testing", "General")
> +

It feels like this file should use a "with Files('**'):" for Testing :: General as a default rule and then leave it to overrides to assign a more specific component. That will be simpler than cherry picking orphaned files in this moz.build.

But this approach works.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1a53ff436568
annotate rest of testing and toolkit. r=gps

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/1a53ff436568