Closed
Bug 1328351
Opened 7 years ago
Closed 7 years ago
[meta] - tracking bug for getting BUG_COMPONENT specified for all files in the tree
Categories
(Testing :: General, defect)
Testing
General
Tracking
(firefox57 fixed)
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: jmaher, Assigned: jmaher)
References
(Depends on 1 open bug, Blocks 2 open bugs)
Details
(Keywords: meta)
Attachments
(1 file, 2 obsolete files)
2.41 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•7 years ago
|
||
looking at third_party/ this is rust libraries vendored in, there is no real component here. looking at stylo/ there are a lot of changes going in (including test files), but there are no bugs associated with the changes, I am looking to see what to do about stylo/. we also have the b2g/ directory, I am not sure I will get clear ownership there. Ignoring those 3 and what is filed, I still have bugs to file for: browser db docshell mfbt mobile modules nsprpub testing (last part of web-platform/tests/) toolkit widget I would expect getting that list cut in half in the next 2 weeks.
Assignee | ||
Comment 2•7 years ago
|
||
what work remains is: browser (probably in 2 or 3 parts) mfbt nsprpub testing (last part of web-platform/tests/) toolkit (partially done) widget (probably in 2 parts)
Assignee | ||
Comment 3•7 years ago
|
||
I now have: UNKNOWN mfbt nsprpub servo testing (awsy, loose files, web-platform - web-platform is big, so leaving in the unknown bucket) mostly done, need polish, new files: mobile services third_party toolkit xpfe
Comment 4•7 years ago
|
||
PSA: you can now use '**' as the file pattern for `mach file-info` and you won't get errors from invalid moz.build files that are part of moz.build's test harness. Now, it will take a long time to run. But at least it won't error.
Assignee | ||
Comment 5•7 years ago
|
||
Assignee | ||
Comment 6•7 years ago
|
||
forgot one file, this should be good to go
Attachment #8903761 -
Attachment is obsolete: true
Attachment #8903761 -
Flags: review?(ted)
Attachment #8907117 -
Flags: review?(ted)
Assignee | ||
Comment 8•7 years ago
|
||
Ted, this should be a final patch, I would appreciate a review or redirect to someone else.
Attachment #8907117 -
Attachment is obsolete: true
Attachment #8907117 -
Flags: review?(ted)
Attachment #8907346 -
Flags: review?(ted)
Comment 9•7 years ago
|
||
Comment on attachment 8907346 [details] [diff] [review] annotate many remaining files in testing/ and toolkit/ with BUG_COMPONENTS Review of attachment 8907346 [details] [diff] [review]: ----------------------------------------------------------------- ::: testing/moz.build @@ +2,5 @@ > + BUG_COMPONENT = ("Testing", "AWSY") > + > +with Files("config/**"): > + BUG_COMPONENT = ("Testing", "General") > + It feels like this file should use a "with Files('**'):" for Testing :: General as a default rule and then leave it to overrides to assign a more specific component. That will be simpler than cherry picking orphaned files in this moz.build. But this approach works.
Attachment #8907346 -
Flags: review?(ted) → review+
Comment 10•7 years ago
|
||
Pushed by jmaher@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1a53ff436568 annotate rest of testing and toolkit. r=gps
Comment 11•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1a53ff436568
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•