Closed Bug 1328351 Opened 7 years ago Closed 7 years ago

[meta] - tracking bug for getting BUG_COMPONENT specified for all files in the tree

Categories

(Testing :: General, defect)

defect
Not set
normal

Tracking

(firefox57 fixed)

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: jmaher, Assigned: jmaher)

References

(Depends on 1 open bug, Blocks 2 open bugs)

Details

(Keywords: meta)

Attachments

(1 file, 2 obsolete files)

      No description provided.
Depends on: 1326465
Depends on: 1328356
Depends on: 1328361
No longer depends on: 1328361
Depends on: 1328361
Depends on: 1328383
Depends on: 1328388
Depends on: 1330325
Depends on: 1330329
Depends on: 1330399
Depends on: 1330402
Depends on: 1332392
Depends on: 1332394
Depends on: 1332423
Depends on: 1333180
Depends on: 1333451
Depends on: 1333460
Depends on: 1333493
Depends on: 1333552
Blocks: 1319943
Depends on: 1334242
Depends on: 1334476
Depends on: 1334525
Depends on: 1334529
Depends on: 1334541
Depends on: 1334551
Depends on: 1335082
Depends on: 1335099
Depends on: 1335181
Depends on: 1333439
Depends on: 1337806
Blocks: 1277337
Depends on: 1338320
Depends on: 1339232
Depends on: 1341794
Depends on: 1341799
Depends on: 1341808
Depends on: 1341876
Depends on: 1341819
Depends on: 1341801
Depends on: 1344470
Depends on: 1344471
Depends on: 1344829
Depends on: 1344837
Depends on: 1344860
Depends on: 1344871
Depends on: 1344876
Depends on: 1344878
Depends on: 1344891
Depends on: 1345506
Depends on: 1345514
Depends on: 1345530
Depends on: 1345542
Depends on: 1345556
looking at third_party/ this is rust libraries vendored in, there is no real component here.
looking at stylo/ there are a lot of changes going in (including test files), but there are no bugs associated with the changes, I am looking to see what to do about stylo/.
we also have the b2g/ directory, I am not sure I will get clear ownership there.

Ignoring those 3 and what is filed, I still have bugs to file for:
browser
db
docshell
mfbt
mobile
modules
nsprpub
testing (last part of web-platform/tests/)
toolkit
widget

I would expect getting that list cut in half in the next 2 weeks.
Depends on: 1345618
Depends on: 1345627
Depends on: 1350473
Depends on: 1350496
what work remains is:
browser (probably in 2 or 3 parts)
mfbt
nsprpub
testing (last part of web-platform/tests/)
toolkit (partially done)
widget (probably in 2 parts)
Depends on: 1351067
Depends on: 1355088
Depends on: 1355089
Depends on: 1382830
I now have:
UNKNOWN
  mfbt
  nsprpub
  servo
  testing (awsy, loose files, web-platform - web-platform is big, so leaving in the unknown bucket)

mostly done, need polish, new files:
  mobile
  services
  third_party
  toolkit
  xpfe
Depends on: 1391735
PSA: you can now use '**' as the file pattern for `mach file-info` and you won't get errors from invalid moz.build files that are part of moz.build's test harness. Now, it will take a long time to run. But at least it won't error.
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #8903761 - Flags: review?(ted)
forgot one file, this should be good to go
Attachment #8903761 - Attachment is obsolete: true
Attachment #8903761 - Flags: review?(ted)
Attachment #8907117 - Flags: review?(ted)
Ted, this should be a final patch, I would appreciate a review or redirect to someone else.
Attachment #8907117 - Attachment is obsolete: true
Attachment #8907117 - Flags: review?(ted)
Attachment #8907346 - Flags: review?(ted)
Comment on attachment 8907346 [details] [diff] [review]
annotate many remaining files in testing/ and toolkit/ with BUG_COMPONENTS

Review of attachment 8907346 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/moz.build
@@ +2,5 @@
> +    BUG_COMPONENT = ("Testing", "AWSY")
> +
> +with Files("config/**"):
> +    BUG_COMPONENT = ("Testing", "General")
> +

It feels like this file should use a "with Files('**'):" for Testing :: General as a default rule and then leave it to overrides to assign a more specific component. That will be simpler than cherry picking orphaned files in this moz.build.

But this approach works.
Attachment #8907346 - Flags: review?(ted) → review+
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1a53ff436568
annotate rest of testing and toolkit. r=gps
https://hg.mozilla.org/mozilla-central/rev/1a53ff436568
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Depends on: 1676922
You need to log in before you can comment on or make changes to this bug.