Open Bug 1330343 Opened 6 years ago Updated 4 months ago

Anything visited from the locationbar is marked as "typed"

Categories

(Firefox :: Address Bar, defect, P3)

Product:
Firefox
Component:
Address Bar
Type:
defect
Points:
5

Tracking

()

People

(Reporter: mak, Unassigned)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Whiteboard: [snt-])

User Story

Currently "typed" is just synonym for "picked from the urlbar".
Engineering thinks a real typed information would not be particularly good as a user signal, since a url may be typed just to check it (after having rwad it on a magazine or somewhere else).
On the other side the information of being picked from the urlbar may be of value, so we could just evaluate a rename.
Recent changes to urlbarBindings.xml made us always (apart from a few cases like switch to tab) go through _loadURL. Or maybe we always did, but now we have a bunch of new result types.

_loadURL calls addToUrlbarHistory(url); that calls PlacesUIUtils.markPageAsTyped.

first, addToUrlbarHistory should imo be removed, and markPageAsTyped should grow an optional "win" argument. At least it will be clear what it does.

This creates a bias on autofill and frecency, that may not always be wanted. We should not mark as typed any kind of result, it should rather be an opt-in depending on the result type (good for visiturl, not for search suggestions, for example).
See Also: → 1461844
Blocks: 1467631
Blocks: qb-results-papercuts
No longer blocks: qb-results-papercuts
Points: --- → 5
Depends on: 1635100
Severity: normal → S3
Priority: P2 → P3
Whiteboard: [fxsearch] → [snt-]
User Story: (updated)
You need to log in before you can comment on or make changes to this bug.