Open Bug 1330343 Opened 4 years ago Updated 6 months ago

Anything visited from the locationbar is marked as "typed"

Categories

(Firefox :: Address Bar, defect, P2)

defect
Points:
5

Tracking

()

People

(Reporter: mak, Unassigned)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Whiteboard: [fxsearch])

Recent changes to urlbarBindings.xml made us always (apart from a few cases like switch to tab) go through _loadURL. Or maybe we always did, but now we have a bunch of new result types.

_loadURL calls addToUrlbarHistory(url); that calls PlacesUIUtils.markPageAsTyped.

first, addToUrlbarHistory should imo be removed, and markPageAsTyped should grow an optional "win" argument. At least it will be clear what it does.

This creates a bias on autofill and frecency, that may not always be wanted. We should not mark as typed any kind of result, it should rather be an opt-in depending on the result type (good for visiturl, not for search suggestions, for example).
See Also: → 1461844
Blocks: 1467631
No longer blocks: qb-results-papercuts
Points: --- → 5
Depends on: 1635100
You need to log in before you can comment on or make changes to this bug.