Add Fennec support to "Addon:Install" command

NEW
Unassigned

Status

defect
P3
normal
3 years ago
7 months ago

People

(Reporter: intermittent-bug-filer, Unassigned)

Tracking

({test-disabled})

Version 3
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox51 unaffected, firefox52 disabled, firefox53 disabled)

Details

Attachments

(1 attachment)

Generally installing add-ons should work for Fennec, so the assert.firefox() call in driver.js might not be necessary. But I cannot proof this at the moment because we only support installing add-ons from a file path. With that we would have to update the install_addon() command in Marionette driver so it will copy the file to the remote filesystem. Otherwise Fennec won't be able to access it for installation and bails out with file not found.

Until the above has been implemented we have to skip the addon tests for Fennec.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)
Comment on attachment 8826155 [details]
Bug 1330598 - Skip Marionette's addon unit tests for Fennec."

https://reviewboard.mozilla.org/r/104172/#review105160

r+wc

::: testing/marionette/harness/marionette_harness/tests/unit/test_addons.py:14
(Diff revision 1)
> -
>  
>  here = os.path.abspath(os.path.dirname(__file__))
>  
>  
>  class TestAddons(MarionetteTestCase):

You're skipping all the tests in here. Why not just skip the entire test module in the manifest?
Attachment #8826155 - Flags: review?(mjzffr) → review+

Comment 4

3 years ago
mozreview-review-reply
Comment on attachment 8826155 [details]
Bug 1330598 - Skip Marionette's addon unit tests for Fennec."

https://reviewboard.mozilla.org/r/104172/#review105160

> You're skipping all the tests in here. Why not just skip the entire test module in the manifest?

We can indeed do that. I will change it.
Comment hidden (mozreview-request)

Comment 6

3 years ago
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/181226e8933b
Skip Marionette's addon unit tests for Fennec." r=maja_zf
Please uplift this skip patch as test-only to aurora. Thanks.
Keywords: leave-open
Whiteboard: [disabled][checkin-needed-aurora]
Closing as intermittent has not been seen in last 45 days
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → WORKSFORME
It's due a missing feature in Marionette for Fennec. So the test is skipped on Android, but still existent.
Status: RESOLVED → REOPENED
OS: Unspecified → Android
Hardware: Unspecified → ARM
Resolution: WORKSFORME → ---
Can you fill us in on what the next step here is?
Flags: needinfo?(hskupin)
Priority: -- → P3
Just see comment 11. We can unskip once Marionette supports installing addons for Fennec.
Flags: needinfo?(hskupin)
Keywords: test-disabled
Assignee: hskupin → nobody
Status: REOPENED → NEW
The leave-open keyword is there and there is no activity for 6 months.
:automatedtester, maybe it's time to close this bug?
Flags: needinfo?(dburns)
It might make more sense to move this bug to an implementation bug given that this feature isn't supported for Fennec yet.
Flags: needinfo?(dburns)
Summary: Intermittent test_addons.py TestAddons.test_install_* | UnsupportedOperationException: Only supported in Firefox → Add Fennec support to "Addon:Install" command
Whiteboard: [disabled]
You need to log in before you can comment on or make changes to this bug.