1330598 - Add Fennec support to "Addon:Install" command

Status: RESOLVED WONTFIX

(Remote Protocol :: Marionette, defect, P3)

Description

[Treeherder Bug Filer]

Filed by: hskupin [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=68333842&repo=autoland

https://queue.taskcluster.net/v1/task/ThheqaUNS86Gb8r13Gu71Q/runs/0/artifacts/public/logs/live_backing.log

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Generally installing add-ons should work for Fennec, so the assert.firefox() call in driver.js might not be necessary. But I cannot proof this at the moment because we only support installing add-ons from a file path. With that we would have to update the install_addon() command in Marionette driver so it will copy the file to the remote filesystem. Otherwise Fennec won't be able to access it for installation and bails out with file not found.

Until the above has been implemented we have to skip the addon tests for Fennec.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1330598 - Skip Marionette's addon unit tests for Fennec."

The tests have to be skipped because Marionette server only allows the
installation of add-ons for Firefox. Once Fennec gets white-listed, it
would be still necessary to copy the to install XPI to the device file
system.

Review commit: https://reviewboard.mozilla.org/r/104172/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/104172/

Comment 3

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8826155 [details]
Bug 1330598 - Skip Marionette's addon unit tests for Fennec."

https://reviewboard.mozilla.org/r/104172/#review105160

r+wc

::: testing/marionette/harness/marionette_harness/tests/unit/test_addons.py:14
(Diff revision 1)
> -
>  
>  here = os.path.abspath(os.path.dirname(__file__))
>  
>  
>  class TestAddons(MarionetteTestCase):

You're skipping all the tests in here. Why not just skip the entire test module in the manifest?

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8826155 [details]
Bug 1330598 - Skip Marionette's addon unit tests for Fennec."

https://reviewboard.mozilla.org/r/104172/#review105160

> You're skipping all the tests in here. Why not just skip the entire test module in the manifest?

We can indeed do that. I will change it.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8826155 [details]
Bug 1330598 - Skip Marionette's addon unit tests for Fennec."

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/104172/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/181226e8933b
Skip Marionette's addon unit tests for Fennec." r=maja_zf

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/181226e8933b

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Please uplift this skip patch as test-only to aurora. Thanks.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5b114d533644

Comment 10

[David Burns :automatedtester]

Closing as intermittent has not been seen in last 45 days

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

It's due a missing feature in Marionette for Fennec. So the test is skipped on Android, but still existent.

Comment 12

[Andreas Tolfsen ❲:ato❳]

Can you fill us in on what the next step here is?

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Just see comment 11. We can unskip once Marionette supports installing addons for Fennec.

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:automatedtester, maybe it's time to close this bug?

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+2]]

It might make more sense to move this bug to an implementation bug given that this feature isn't supported for Fennec yet.

Comment 16

[Henrik Skupin [:whimboo][⌚️UTC+2]]

With Fennec being unsupported now on central this bug turns to be a wontfix.

Note that GeckoView doesn't have basic webextension support yet (see bug 1511077), but once it has we could perfectly add that feature for mobile.