1330977 - Truncated Advanced tab of in-content preferences

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Alice0775 White]

Attachment: screenshot

[Tracking Requested - why for this release]: Visual glitch

Reproducible : always in specific browser width (around 1260px)

Steps To reproduce:
1. Tools > Options > Advanced
2. Click on General, then Click on Update, and then Click on Network

Actual Results:
Truncated Network tab.  see attached screenshot

Comment 1

[Alice0775 White]

More reliable steps.

Steps To reproduce:
1. Tools > Options > Advanced
2. Click on Network
3. Close tab

4. Open Newtab
5. Tools > Options > Advanced
6. Click on General, then Click on Update, and then Click on Network

Comment 2

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=01298d3fae23674314f4f4e7b885ce3713644896&tochange=95fabc8be84934ce322e7fe3ae56ef822e4a480

Suspect: 95fabc8be849	beachjar — Bug 1324170 - Change "Learn More" links to always align after text in about:preferences r=jaws

Comment 3

[Alice0775 White]

Attachment: screenshot2

Aha, just open Advanced tab is enough to reproduce the truncating.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1330977 - Flex the labels of boxes that have Learn More links on them.

Review commit: https://reviewboard.mozilla.org/r/104570/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/104570/

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8826663 [details]
Bug 1330977 - Flex the labels of boxes that have Learn More links on them.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/104570/diff/1-2/

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8826663 [details]
Bug 1330977 - Flex the labels of boxes that have Learn More links on them.

https://reviewboard.mozilla.org/r/104570/#review106778

Patch looks okay to me - though the commit message is kinda long. Can you put a short first-line on the commit message (with the r flag), and expand / go into detail on some lines below it? 

Example:

Bug 1330977 - Flex the labels of boxes that have Learn More links on them. r?mconley

This is so that the text will wrap and not force the box to have its full width. etc

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8826663 [details]
Bug 1330977 - Flex the labels of boxes that have Learn More links on them.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/104570/diff/2-3/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b3f4b8aa71e0
Flex the labels of boxes that have Learn More links on them. r=mconley

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/b3f4b8aa71e0

Comment 10

[Matthew N. [:MattN]]

Screenshots of the change: https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=96cb95af530477edb66ae48d98c18533476e57bb&newProject=mozilla-central&newRev=d5343b0f7e6a9619dfdf333d259cff6b4f773bff&filter=_preferences_