Closed Bug 1330977 Opened 3 years ago Closed 3 years ago

Truncated Advanced tab of in-content preferences

Categories

(Firefox :: Preferences, defect)

53 Branch
x86
Windows 10
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 53
Tracking Status
firefox-esr45 --- unaffected
firefox50 --- unaffected
firefox51 --- unaffected
firefox52 --- unaffected
firefox53 --- fixed

People

(Reporter: alice0775, Assigned: jaws)

References

Details

(Keywords: regression)

Attachments

(3 files)

Attached image screenshot
[Tracking Requested - why for this release]: Visual glitch

Reproducible : always in specific browser width (around 1260px)

Steps To reproduce:
1. Tools > Options > Advanced
2. Click on General, then Click on Update, and then Click on Network

Actual Results:
Truncated Network tab.  see attached screenshot
More reliable steps.

Steps To reproduce:
1. Tools > Options > Advanced
2. Click on Network
3. Close tab

4. Open Newtab
5. Tools > Options > Advanced
6. Click on General, then Click on Update, and then Click on Network
Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=01298d3fae23674314f4f4e7b885ce3713644896&tochange=95fabc8be84934ce322e7fe3ae56ef822e4a480

Suspect: 95fabc8be849	beachjar — Bug 1324170 - Change "Learn More" links to always align after text in about:preferences r=jaws
Blocks: 1324170
Flags: needinfo?(beachjar)
Summary: Truncated Network tab of in-content preferences → Truncated Advanced tab of in-content preferences
Attached image screenshot2
Aha, just open Advanced tab is enough to reproduce the truncating.
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Flags: needinfo?(beachjar)
Comment on attachment 8826663 [details]
Bug 1330977 - Flex the labels of boxes that have Learn More links on them.

https://reviewboard.mozilla.org/r/104570/#review106778

Patch looks okay to me - though the commit message is kinda long. Can you put a short first-line on the commit message (with the r flag), and expand / go into detail on some lines below it? 

Example:

Bug 1330977 - Flex the labels of boxes that have Learn More links on them. r?mconley

This is so that the text will wrap and not force the box to have its full width. etc
Attachment #8826663 - Flags: review?(mconley) → review+
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b3f4b8aa71e0
Flex the labels of boxes that have Learn More links on them. r=mconley
https://hg.mozilla.org/mozilla-central/rev/b3f4b8aa71e0
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
You need to log in before you can comment on or make changes to this bug.