1331006 - Create a rule to import test globals for mochitest/chrome/browser tests from SimpleTest/EventUtils

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, defect)

Description

[Mark Banner (:standard8)]

SimpleTest & EventUtils get used quite a bit in tests. Rather than trying to list all their global values in the *.eslintrc.js files, I've created a rule to import the globals automatically.

This knocks off another 300 no-undef errors off the list.

Comment 1

[Mark Banner (:standard8)]

Also included are some other globals, and missing .eslintrc.js files for new test directories.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1331006 - [eslint] Define more globals, and add a rule to import test globals from SimpleTest/EventUtils.

Review commit: https://reviewboard.mozilla.org/r/104562/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/104562/

Comment 3

[Dave Townsend [:mossop]]

Comment on attachment 8826659 [details]
Bug 1331006 - [eslint] Define more globals, and add a rule to import test globals from SimpleTest/EventUtils.

https://reviewboard.mozilla.org/r/104562/#review105718

::: toolkit/components/windowcreator/test/test_nsFind.html:159
(Diff revision 1)
> -  function assertFound(node, searchValue) {
> -    ok(find(node, searchValue), "\"" + searchValue + "\" not found");
> +  function assertFound(node, value) {
> +    ok(find(node, value), "\"" + value + "\" not found");
>    }
>  
> -  function assertNotFound(node, searchValue) {
> -    ok(!find(node, searchValue), "\"" + searchValue + "\" found");
> +  function assertNotFound(node, value) {
> +    ok(!find(node, value), "\"" + value + "\" found");

Why were all these changes necessary?

::: tools/lint/eslint/eslint-plugin-mozilla/lib/rules/import-test-globals.js:34
(Diff revision 1)
> +  // Public
> +  // ---------------------------------------------------------------------------
> +
> +  return {
> +    Program: function(node) {
> +      //

Unnecessary comment?

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 8826659 [details]
Bug 1331006 - [eslint] Define more globals, and add a rule to import test globals from SimpleTest/EventUtils.

https://reviewboard.mozilla.org/r/104562/#review105718

> Why were all these changes necessary?

Mochitests have the "no-shadow" rule enabled. Adding the .eslintrc.js file to the directory triggered the failures.

> Unnecessary comment?

Yep, fixed. I also updated the documentation at the top of the file.

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 8826659 [details]
Bug 1331006 - [eslint] Define more globals, and add a rule to import test globals from SimpleTest/EventUtils.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/104562/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d4fe24cd664
[eslint] Define more globals, and add a rule to import test globals from SimpleTest/EventUtils. r=mossop

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8d4fe24cd664