Intermittent test_localization.py TestL10n.test_localize_* | Don't use entities and properties not known to all supported applications

RESOLVED FIXED in Firefox 52

Status

Testing
Marionette
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: Treeherder Bug Filer, Assigned: whimboo)

Tracking

(Depends on: 1 bug, {intermittent-failure})

Version 3
mozilla53
intermittent-failure
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox51 unaffected, firefox52 fixed, firefox53 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Updated

a year ago
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
status-firefox52: --- → affected
status-firefox53: --- → affected
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Attachment #8827656 - Flags: review?(mjzffr)
(Assignee)

Updated

a year ago
Attachment #8827656 - Flags: review?(mjzffr)
(Assignee)

Comment 2

a year ago
While running the tests with `--gecko-log -` I noticed the following line:

> WARNING: Failed to open external DTD: publicId "" systemId "resource:///res/dtd/xhtml11.dtd" base "moz-nullprincipal:{2ed3096c-8b6e-1947-8a63-b9bba6a127dd}" URL "resource:///res/dtd/xhtml11.dtd": file /builds/slave/m-cen-m64-d-000000000000000000/build/src/parser/htmlparser/nsExpatDriver.cpp, line 702

As it looks like we no longer include this DTD into our base code, which means it can also be removed.
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Attachment #8827656 - Flags: review?(ato)

Comment 4

a year ago
mozreview-review
Comment on attachment 8827656 [details]
Bug 1331037 - Fix failures in test_localization.py for Fennec.

https://reviewboard.mozilla.org/r/105270/#review106330

I don’t really have the specialist insight to say if this XUL change is right or not, but I’m trusting you it is.  It looks technically correct.
Attachment #8827656 - Flags: review?(ato) → review+
(Assignee)

Comment 5

a year ago
mozreview-review-reply
Comment on attachment 8827656 [details]
Bug 1331037 - Fix failures in test_localization.py for Fennec.

https://reviewboard.mozilla.org/r/105270/#review106330

I know but I cannot ask anyone else from the team either. But I checked the changes by inspecting the open test dialog, and that the correct content is shown. Beside that the l10n tests also proof that it works. Thanks for the review.

Comment 6

a year ago
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/123ee1fcc268
Fix failures in test_localization.py for Fennec. r=ato

Comment 7

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/123ee1fcc268
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
(Assignee)

Comment 8

a year ago
Please uplift this test-only patch to aurora. Thanks.
Whiteboard: [checkin-needed-aurora]
status-firefox51: --- → unaffected

Comment 9

a year ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/ed6e5d97950a
status-firefox52: affected → fixed
Flags: in-testsuite+
Whiteboard: [checkin-needed-aurora]
Depends on: 1344267
You need to log in before you can comment on or make changes to this bug.