1331037 - Intermittent test_localization.py TestL10n.test_localize_* | Don't use entities and properties not known to all supported applications

Status: RESOLVED FIXED

(Testing :: Marionette Client and Harness, defect)

Description

[Treeherder Bug Filer]

Filed by: hskupin [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=68858836&repo=autoland

https://queue.taskcluster.net/v1/task/IxxZjeQ8SAaPnVB3SJs98A/runs/0/artifacts/public/logs/live_backing.log

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1331037 - Fix failures in test_localization.py for Fennec.

Fennec uses a different set of DTD and property files. As such the current
entity and property names do not work. But for both types we can rely on
brandFullName, which always contains the application name.

Review commit: https://reviewboard.mozilla.org/r/105270/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/105270/

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

While running the tests with `--gecko-log -` I noticed the following line:

> WARNING: Failed to open external DTD: publicId "" systemId "resource:///res/dtd/xhtml11.dtd" base "moz-nullprincipal:{2ed3096c-8b6e-1947-8a63-b9bba6a127dd}" URL "resource:///res/dtd/xhtml11.dtd": file /builds/slave/m-cen-m64-d-000000000000000000/build/src/parser/htmlparser/nsExpatDriver.cpp, line 702

As it looks like we no longer include this DTD into our base code, which means it can also be removed.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8827656 [details]
Bug 1331037 - Fix failures in test_localization.py for Fennec.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/105270/diff/1-2/

Comment 4

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8827656 [details]
Bug 1331037 - Fix failures in test_localization.py for Fennec.

https://reviewboard.mozilla.org/r/105270/#review106330

I don’t really have the specialist insight to say if this XUL change is right or not, but I’m trusting you it is.  It looks technically correct.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8827656 [details]
Bug 1331037 - Fix failures in test_localization.py for Fennec.

https://reviewboard.mozilla.org/r/105270/#review106330

I know but I cannot ask anyone else from the team either. But I checked the changes by inspecting the open test dialog, and that the correct content is shown. Beside that the l10n tests also proof that it works. Thanks for the review.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/123ee1fcc268
Fix failures in test_localization.py for Fennec. r=ato

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/123ee1fcc268

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Please uplift this test-only patch to aurora. Thanks.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ed6e5d97950a

Comment 10

[BMO Automation]

Moving bug to Testing::Marionette Client and Harness component per bug 1815831.