Closed Bug 1331265 Opened 4 years ago Closed 4 years ago

Error "now.getTime is not a function" when creating a task with entry date

Categories

(Calendar :: Tasks, defect)

Lightning 5.3
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bv1578, Assigned: bv1578)

References

Details

Attachments

(1 file)

Step to reproduce:

As described in summary: create a new task, activate the entry date, save and close the dialog;

--> the error "now.getTime is not a function" appears in the console.

It's caused by a typo from bug 1063085.
Attached patch patch-v1Splinter Review
fix
Attachment #8826941 - Flags: review?(makemyday)
Comment on attachment 8826941 [details] [diff] [review]
patch-v1

Review of attachment 8826941 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, r=me

We should take this for 5.4, too.
Attachment #8826941 - Flags: review?(makemyday)
Attachment #8826941 - Flags: review+
Attachment #8826941 - Flags: approval-calendar-aurora?(philipp)
Comment on attachment 8826941 [details] [diff] [review]
patch-v1

Review of attachment 8826941 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for catching this! I assume 5.4+ is the only place where this is an issue? If not, blanket a=me for other branches.
Attachment #8826941 - Flags: approval-calendar-aurora?(philipp) → approval-calendar-aurora+
Pushed to comm-central
https://hg.mozilla.org/comm-central/rev/753f701af7a2
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Pushed to comm-aurora
https://hg.mozilla.org/releases/comm-aurora/rev/86b109c48a5a

This also have to go on beta.

MakeMyDay, is there currently any restriction about Beta (5.3)?
Flags: needinfo?(makemyday)
Version: Lightning 5.3 → Lightning 5.4
You should have set the "Target Milestone", not the Version.
Target Milestone: --- → 5.4
Version: Lightning 5.4 → Trunk
Can someone please set approval-calendar-beta+ here, otherwise my queries don't see it.
Comment on attachment 8826941 [details] [diff] [review]
patch-v1

No, there's none, go ahead. Given that the patch from the original bug landed in 3.6 (which also should be the version of this bug then), the patch should be uplifted up to ESR (carrying forward Philipp's blanko a+).

Now that beta builds are working again, there will probably one more beta of TB 51 this week if there are any uplifts.
Flags: needinfo?(makemyday)
Attachment #8826941 - Flags: approval-calendar-esr+
Attachment #8826941 - Flags: approval-calendar-beta+
Version: Trunk → Lightning 3.6
There are uplifts to beta 51, currently this bug and two others and I've already uplifted one.
Note that bug 1324006 is also awaiting calendar approval. Maybe you want to give that and I can include it in the uplift.
I don't think this has to go to ESR. If I read it correctly this regression was introduced in Lightning 5.3 with Bug 1280898 (https://hg.mozilla.org/comm-central/rev/fd02e757b142). Bug 1063085 is not related.
Comment on attachment 8826941 [details] [diff] [review]
patch-v1

Yes, you're right. Thanks for cross checking!
Attachment #8826941 - Flags: approval-calendar-esr+
Blocks: 1280898
No longer blocks: 1063085
Version: Lightning 3.6 → Lightning 5.3
Pushed to comm-beta:
https://hg.mozilla.org/releases/comm-beta/rev/edbc5069cfa0


(In reply to Stefan Sitter from comment #10)
> ...this regression was introduced in Lightning 5.3 with Bug 1280898
> (https://hg.mozilla.org/comm-central/rev/fd02e757b142). Bug 1063085 is not
> related.

Thanks for the right bug number.

(In reply to Jorg K (GMT+1) from comment #6)
> You should have set the "Target Milestone", not the Version.

Thanks for the correction and also for the explanation.
Target Milestone: 5.4 → 5.3
You need to log in before you can comment on or make changes to this bug.