Closed Bug 1331270 Opened 7 years ago Closed 7 years ago

Crash in @0x0 | _GetWindowIcon

Categories

(Core :: Widget: Win32, defect, P1)

Product:
Core
Component:
Widget: Win32
Version:
52 Branch
Platform:
x86
Windows 10
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME
Tracking Flags:
Tracking Status
firefox51 --- unaffected
firefox52 + affected
firefox53 --- affected
firefox54 --- affected

People

(Reporter: MatsPalmgren_bugz, Unassigned)

Details

(4 keywords)

Crash Data

This bug was filed from the Socorro interface and is 
report bp-d56e587d-26eb-4881-8550-a240a2170115.
=============================================================

This looks like a very recent regression in v53 and v52.
The signature first occurs in build 20170112030301 in v53.
The signature first occurs in build 20170114004003 in v52.
Perhaps we can cross-reference those dates to figure out what caused it?
Flags: needinfo?(twalker)
it's very early still, but this is looking like it might become a top crash on 52.0b.

the pushlog for 52.0a2 build 20170114004003 -1 day is:
https://hg.mozilla.org/releases/mozilla-aurora/pushloghtml?fromchange=1e322cd9c7410917d4c5f1fa5b2cd78eb4a79ec6&tochange=be9be2c13b4dc9038b331a91f923a4658014bae4

the pushlog for 53.0a1 build 20170112030301 -2 days is:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8f3b24109e3412b36f97277e31ad66856dc609d6&tochange=97d6f73643940256c0eb61e384c49bf6f6c49847

common patches that landed in those timeframe would be:
Bug 1329616 - Massive increase of focus loss and Unknown Accessibles problems with E10S turned off starting in 2016-12-16 Nightly
Bug 1325676 - Prevent touchscreens on Windows 8.x from instantiating accessibility
Bug 1329971 - tab objects returned by sessions.getRecentlyClosed are missing some data
status-firefox51: --- → unaffected
status-firefox52: --- → affected
status-firefox53: --- → affected
status-firefox54: --- → affected
Keywords: regression
aaron, do you think this crash could be related to bugs 1329616 & 1325676? this one here is only affecting windows 8 & upwards too.
Flags: needinfo?(aklotz)
The module at the top of the crash thread, uxtheme.dll, is not our code.  Patch Tuesday was 20170110. Depending on uptake, patch Tuesday could speculatively be the culprit.
Flags: needinfo?(twalker)
I'm with Tracy on this one. This crash is buried deeply inside Windows GUI code.
Flags: needinfo?(aklotz)
[Tracking Requested - why for this release]: #7 top crash on 52.0b in last 7 days.

STR wanted.

https://crash-stats.mozilla.com/topcrashers/?product=Firefox&version=52.0b&days=7
tracking-firefox52: --- → ?
Priority: -- → P1
Keywords: steps-wanted
Tracking for 52 as a top crash.
tracking-firefox52: ? → +
If we think this is a Windows bug, is anybody following up with Microsoft about it?
Flags: needinfo?(jmathies)
the crashes all seem to have stopped after 54.0a1 build 20170127030206, 53.0a2 build 20170131004003 & 52.0b3. so likely some patch that got uplifted around this time addressed this.

these are some bugs with patches that got uplifted to aurora & beta in the mentioned timeframe:
    1334257 - Crash in mozilla::TIPMessageHandler::SendMessageTimeoutWHook
    1332773 - Unaccessible
    1333736 - Disable usage of new tab page now that loading about:blank twice is no longer an issue
    1320481 - thumbnails cache not cleared when "clear history when firefox closes" is set
    1322349 - With touch enabled, swipe gesture (Windows 10 Insider Preview) doesn't bring down toolbar in fullscreen mode - actionable once released version supports swipe, since 52 is ESR

should we just close the report as WFM?
great news, lets close it out.
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(jmathies)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.