1331276 - Compact theme broken in Private Windows

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Dennis Schubert [:denschub]]

Attachment: Screenshot of a Private Window with the dark compact theme selected

After bug 1314091 landed, Private Windows look broken when opening them with a comapct theme selected. I've attached a screenshot from a private window opened with the dark comapct theme selected.

Note that this is not even the light compact theme, it's something... broken. Looks like a mixture between the compact theme and the default theme.

Comment 1

[Dennis Schubert [:denschub]]

Attachment: Proper dark compact themed window

For reference, this is how it should look like.

Comment 2

[Brian Grinstead [:bgrins]]

Thanks for the report, I can confirm the problem. I'll have a look this week.

Comment 3

[Brian Grinstead [:bgrins]]

It appears that lightweight themes don't get applied in private windows, so I suspect this is due to us changing the selectors to use -moz-lwtheme-darktext / -moz-lwtheme-brighttext instead of the custom attribute that we used to use: https://hg.mozilla.org/mozilla-central/rev/4333fc0c05eb#l12.2.

Gijs, any ideas here?  A couple thoughts would be (1) to allow these lightweight themes to apply to private windows (making a whitelist that contains just the compact themes) or (2) go back to using attributes for the css instead of the :-moz-lwtheme selectors.  I'd prefer 1 if it was feasible since that would let us keep the simpler CSS, and also close any potential gaps between normal and private windows that probably existed before but we didn't notice (due to styles like `#TabsToolbar:not(:-moz-lwtheme)` in browser.css being applied).

Comment 4

[:Gijs (out for now; he/him)]

We should just enable lightweight themes for private windows. See bug 854126.

Comment 5

[:Gijs (out for now; he/him)]

(In reply to :Gijs from comment #4)
> We should just enable lightweight themes for private windows. See bug 854126.

(which has an extant patch but got stuck on OS X compat and then became sad and lonely - I wouldn't expect fixing it to be that difficult - famous last words, of course...)

Comment 7

[Dennis Schubert [:denschub]]

Sweet, works fine now. Thanks everyone!

Comment 8

[Paul Silaghi, QA [:pauly]]

Verified fixed Fx 53b1 Win 10, Ubuntu 14.04, OS X 10.11.