Closed
Bug 1331296
Opened 7 years ago
Closed 7 years ago
Remove support for -moz-calc()
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: bmo, Assigned: bmo)
References
(Blocks 1 open bug)
Details
(Keywords: addon-compat, dev-doc-complete, site-compat)
Attachments
(5 files)
59 bytes,
text/x-review-board-request
|
heycam
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
heycam
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
tromey
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
heycam
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
tromey
:
review+
|
Details |
This is a follow-up for bug 771678 comment 7. I will remove prefixed CSS function -moz-calc from the tree.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 6•7 years ago
|
||
1st Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=25a81acc2aa13318fc15834de72f8e0ed33f10b0
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Updated•7 years ago
|
Blocks: unprefix
Summary: Remove the support of -moz-calc → Remove support for -moz-calc()
Updated•7 years ago
|
Assignee | ||
Comment 12•7 years ago
|
||
2nd Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c552305ed4f78c03a599f814ab6c34bcb7e75249 Exclude changes in mask-image-2.html since it's just mistakenly included in first upload.
Assignee | ||
Updated•7 years ago
|
Attachment #8827028 -
Flags: review?(cam)
Attachment #8827029 -
Flags: review?(cam)
Attachment #8827030 -
Flags: review?(ttromey)
Attachment #8827031 -
Flags: review?(cam)
Attachment #8827032 -
Flags: review?(ttromey)
Comment 13•7 years ago
|
||
mozreview-review |
Comment on attachment 8827028 [details] Bug 1331296 : Part 1 - Remove or unprefix -moz-calc() from layout tests. https://reviewboard.mozilla.org/r/104852/#review105826
Attachment #8827028 -
Flags: review?(cam) → review+
Comment 14•7 years ago
|
||
mozreview-review |
Comment on attachment 8827029 [details] Bug 1331296 : Part 2 - Unprefix -moz-calc() in dom tests. https://reviewboard.mozilla.org/r/104854/#review105828
Attachment #8827029 -
Flags: review?(cam) → review+
Comment 15•7 years ago
|
||
mozreview-review |
Comment on attachment 8827031 [details] Bug 1331296 : Part 4 - Remove CSS parser support of -moz-calc(). https://reviewboard.mozilla.org/r/104858/#review105830 ::: layout/style/nsCSSParser.cpp:7855 (Diff revision 2) > > static bool > IsCSSTokenCalcFunction(const nsCSSToken& aToken) > { > return aToken.mType == eCSSToken_Function && > - (aToken.mIdent.LowerCaseEqualsLiteral("calc") || > + (aToken.mIdent.LowerCaseEqualsLiteral("calc")); Nit: remove the parens around the function call.
Attachment #8827031 -
Flags: review?(cam) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 21•7 years ago
|
||
mozreview-review |
Comment on attachment 8827030 [details] Bug 1331296 : Part 3 - Remove -moz-calc() from DevTool tests. https://reviewboard.mozilla.org/r/104856/#review105950 Thank you.
Attachment #8827030 -
Flags: review?(ttromey) → review+
Comment 22•7 years ago
|
||
mozreview-review |
Comment on attachment 8827032 [details] Bug 1331296 : Part 5 - Update DevTool CSS property database. https://reviewboard.mozilla.org/r/104860/#review105956 Thank you for doing this. Looks good.
Attachment #8827032 -
Flags: review?(ttromey) → review+
Assignee | ||
Comment 23•7 years ago
|
||
3rd Try before landing: https://treeherder.mozilla.org/#/jobs?repo=try&revision=08771062c91c82f088fea96bdd54a08be40675cc
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 29•7 years ago
|
||
Try looks good. Ready to go.
Comment 30•7 years ago
|
||
Pushed by tlin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bcdb1c9f405b Part 1 - Remove or unprefix -moz-calc() from layout tests. r=heycam https://hg.mozilla.org/integration/autoland/rev/0cd431a10e07 Part 2 - Unprefix -moz-calc() in dom tests. r=heycam https://hg.mozilla.org/integration/autoland/rev/b2a57de4472d Part 3 - Remove -moz-calc() from DevTool tests. r=tromey https://hg.mozilla.org/integration/autoland/rev/62fa067420ee Part 4 - Remove CSS parser support of -moz-calc(). r=heycam https://hg.mozilla.org/integration/autoland/rev/3ea611dc2979 Part 5 - Update DevTool CSS property database. r=tromey
Comment 31•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/bcdb1c9f405b https://hg.mozilla.org/mozilla-central/rev/0cd431a10e07 https://hg.mozilla.org/mozilla-central/rev/b2a57de4472d https://hg.mozilla.org/mozilla-central/rev/62fa067420ee https://hg.mozilla.org/mozilla-central/rev/3ea611dc2979
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Comment 32•7 years ago
|
||
Posted the site compatibility doc: https://www.fxsitecompat.com/en-CA/docs/2017/moz-calc-has-been-removed/
Assignee | ||
Comment 33•7 years ago
|
||
(In reply to Kohei Yoshino [:kohei] from comment #32) > Posted the site compatibility doc: > https://www.fxsitecompat.com/en-CA/docs/2017/moz-calc-has-been-removed/ Thank you, Kohei-san.
Comment 34•6 years ago
|
||
Added notes at the following pages: https://developer.mozilla.org/en-US/docs/Web/CSS/calc#Browser_compatibility https://developer.mozilla.org/en-US/Firefox/Releases/53#CSS Sebastian
Keywords: dev-doc-needed → dev-doc-complete
Comment 35•6 years ago
|
||
Firefox has been having the unpleasant line-height bug, and -moz-calc() could help counteract the bug. Before Firefox's line-height issue gets fixed, making -moz-calc() unavailable is a bad approach in my opinion.
Assignee | ||
Comment 36•6 years ago
|
||
(In reply to Ian Yang from comment #35) > Firefox has been having the unpleasant line-height bug, and -moz-calc() > could help counteract the bug. Before Firefox's line-height issue gets > fixed, making -moz-calc() unavailable is a bad approach in my opinion. Could you be more specific on the line-height bug that you mentioned here ? It'd be great if you can provide a sameple or bug for reference. Rather than using it as a workaround for Firefox line-height issue, I'd love to get it fixed sooner.
Flags: needinfo?(ian.html)
Comment 37•6 years ago
|
||
(In reply to Astley Chen [:astley] (UTC+8) from comment #36) > (In reply to Ian Yang from comment #35) > > Firefox has been having the unpleasant line-height bug, and -moz-calc() > > could help counteract the bug. Before Firefox's line-height issue gets > > fixed, making -moz-calc() unavailable is a bad approach in my opinion. > > Could you be more specific on the line-height bug that you mentioned here ? > It'd be great if you can provide a sameple or bug for reference. > Rather than using it as a workaround for Firefox line-height issue, I'd love > to get it fixed sooner. Please see the following bug report for reference: https://bugzilla.mozilla.org/show_bug.cgi?id=442139
Flags: needinfo?(ian.html)
You need to log in
before you can comment on or make changes to this bug.
Description
•