Closed Bug 1331296 Opened 7 years ago Closed 7 years ago

Remove support for -moz-calc()

Categories

(Core :: CSS Parsing and Computation, defect)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla53
Tracking Flags:
Tracking Status
firefox53 --- fixed

People

(Reporter: bmo, Assigned: bmo)

References

(Blocks 1 open bug)

Details

(Keywords: addon-compat, dev-doc-complete, site-compat)

Attachments

(5 files)

Bug 1331296 : Part 1 - Remove or unprefix -moz-calc() from layout tests.
59 bytes, text/x-review-board-request
heycam
: review+
Details
Bug 1331296 : Part 2 - Unprefix -moz-calc() in dom tests.
59 bytes, text/x-review-board-request
heycam
: review+
Details
Bug 1331296 : Part 3 - Remove -moz-calc() from DevTool tests.
59 bytes, text/x-review-board-request
tromey
: review+
Details
Bug 1331296 : Part 4 - Remove CSS parser support of -moz-calc().
59 bytes, text/x-review-board-request
heycam
: review+
Details
Bug 1331296 : Part 5 - Update DevTool CSS property database.
59 bytes, text/x-review-board-request
tromey
: review+
Details 
This is a follow-up for bug 771678 comment 7.
I will remove prefixed CSS function -moz-calc from the tree.
Assignee: nobody → aschen
Depends on: 771678
Blocks: unprefix
Summary: Remove the support of -moz-calc → Remove support for -moz-calc()
2nd Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c552305ed4f78c03a599f814ab6c34bcb7e75249

Exclude changes in mask-image-2.html since it's just mistakenly included in first upload.
Attachment #8827028 - Flags: review?(cam)
Attachment #8827029 - Flags: review?(cam)
Attachment #8827030 - Flags: review?(ttromey)
Attachment #8827031 - Flags: review?(cam)
Attachment #8827032 - Flags: review?(ttromey)
Comment on attachment 8827028 [details]
Bug 1331296 : Part 1 - Remove or unprefix -moz-calc() from layout tests.

https://reviewboard.mozilla.org/r/104852/#review105826
Attachment #8827028 - Flags: review?(cam) → review+
Comment on attachment 8827029 [details]
Bug 1331296 : Part 2 - Unprefix -moz-calc() in dom tests.

https://reviewboard.mozilla.org/r/104854/#review105828
Attachment #8827029 - Flags: review?(cam) → review+
Comment on attachment 8827031 [details]
Bug 1331296 : Part 4 - Remove CSS parser support of -moz-calc().

https://reviewboard.mozilla.org/r/104858/#review105830

::: layout/style/nsCSSParser.cpp:7855
(Diff revision 2)
>  
>  static bool
>  IsCSSTokenCalcFunction(const nsCSSToken& aToken)
>  {
>    return aToken.mType == eCSSToken_Function &&
> -         (aToken.mIdent.LowerCaseEqualsLiteral("calc") ||
> +         (aToken.mIdent.LowerCaseEqualsLiteral("calc"));

Nit: remove the parens around the function call.
Attachment #8827031 - Flags: review?(cam) → review+
Comment on attachment 8827030 [details]
Bug 1331296 : Part 3 - Remove -moz-calc() from DevTool tests.

https://reviewboard.mozilla.org/r/104856/#review105950

Thank you.
Attachment #8827030 - Flags: review?(ttromey) → review+
Comment on attachment 8827032 [details]
Bug 1331296 : Part 5 - Update DevTool CSS property database.

https://reviewboard.mozilla.org/r/104860/#review105956

Thank you for doing this.  Looks good.
Attachment #8827032 - Flags: review?(ttromey) → review+
Try looks good. Ready to go.
Pushed by tlin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bcdb1c9f405b
Part 1 - Remove or unprefix -moz-calc() from layout tests. r=heycam
https://hg.mozilla.org/integration/autoland/rev/0cd431a10e07
Part 2 - Unprefix -moz-calc() in dom tests. r=heycam
https://hg.mozilla.org/integration/autoland/rev/b2a57de4472d
Part 3 - Remove -moz-calc() from DevTool tests. r=tromey
https://hg.mozilla.org/integration/autoland/rev/62fa067420ee
Part 4 - Remove CSS parser support of -moz-calc(). r=heycam
https://hg.mozilla.org/integration/autoland/rev/3ea611dc2979
Part 5 - Update DevTool CSS property database. r=tromey
(In reply to Kohei Yoshino [:kohei] from comment #32)
> Posted the site compatibility doc:
> https://www.fxsitecompat.com/en-CA/docs/2017/moz-calc-has-been-removed/
Thank you, Kohei-san.
Depends on: 1334064
Firefox has been having the unpleasant line-height bug, and -moz-calc() could help counteract the bug. Before Firefox's line-height issue gets fixed, making -moz-calc() unavailable is a bad approach in my opinion.
(In reply to Ian Yang from comment #35)
> Firefox has been having the unpleasant line-height bug, and -moz-calc()
> could help counteract the bug. Before Firefox's line-height issue gets
> fixed, making -moz-calc() unavailable is a bad approach in my opinion.

Could you be more specific on the line-height bug that you mentioned here ?
It'd be great if you can provide a sameple or bug for reference.
Rather than using it as a workaround for Firefox line-height issue, I'd love to get it fixed sooner.
Flags: needinfo?(ian.html)
(In reply to Astley Chen [:astley] (UTC+8) from comment #36)
> (In reply to Ian Yang from comment #35)
> > Firefox has been having the unpleasant line-height bug, and -moz-calc()
> > could help counteract the bug. Before Firefox's line-height issue gets
> > fixed, making -moz-calc() unavailable is a bad approach in my opinion.
> 
> Could you be more specific on the line-height bug that you mentioned here ?
> It'd be great if you can provide a sameple or bug for reference.
> Rather than using it as a workaround for Firefox line-height issue, I'd love
> to get it fixed sooner.

Please see the following bug report for reference:
https://bugzilla.mozilla.org/show_bug.cgi?id=442139
Flags: needinfo?(ian.html)
You need to log in before you can comment on or make changes to this bug.