1334064 - The "Keep it" and "Cancel" buttons from Add-ons Theme page are smaller

Status: RESOLVED WORKSFORME

(Web Compatibility :: Site Reports, defect)

Description

[Sorina Florean [:sflorean]]

Attachment: Screenshot_2017-01-26-09-44-55.png

Environment: 
Device:  (Android );
Build: Nightly 54.0a1 (2017-01-25);

Steps to reproduce:
1. Open Custom Menu-> Tools ->Add-ons -> Theme;
2. Tap on any theme;
3. Observe the "Keep it" and "Cancel" Buttons.

Expected result: The "Keep it" and "Cancel" buttons are displayed with the same length and width like "You're trying it on" message. 

Actual result:
The "Keep it" and "Cancel" buttons are smaller.

Notes: https://i.imgur.com/JrapTuk.png

Comment 1

[Sorina Florean [:sflorean]]

Notes: Device: Huawei MediaPad M2 (Android 5.1.1).
Builds affected are Nightly 54.0a1 - 2017-01-25 and latest Aurora 53.0a2 - 2017-01-25.

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

@Mike: Do you have an idea what's happening here?

Comment 3

[Mike Taylor [:miketaylr]]

I see `width: -moz-calc(50% - 63px);` on confirm and `width: -moz-calc(50% - 39px);` on the cancel buttons....

mozregression sez:

14:07.28 INFO: Last good revision: 89753b9617c1277c382d761392a7a6787b357744
14:07.28 INFO: First bad revision: 3ea611dc2979d4b377531d4032b72c8ec49d2062
14:07.28 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=89753b9617c1277c382d761392a7a6787b357744&tochange=3ea611dc2979d4b377531d4032b72c8ec49d2062

14:08.59 INFO: Looks like the following bug has the changes which introduced the regression:
https://bugzilla.mozilla.org/show_bug.cgi?id=1331296

"Remove support for -moz-calc()"... ah. There we go.

.persona-previewer .confirm-buttons .cancel {
    float: right;
    width: -moz-calc(50% - 39px);
}

I wonder why they didn't add an unprefixed calc() function?

But let's move this to TE and try to find the right people to update the addons site. In theory they should care!

Comment 4

[Mike Taylor [:miketaylr]]

filed https://github.com/mozilla/addons/issues/332

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Awesmome, thanks!

Comment 6

[Mike Taylor [:miketaylr]]

This is fixed according to https://github.com/mozilla/addons-server/pull/4646. Thanks for the report Sorina!

Comment 7

[Sorina Florean [:sflorean]]

Based on comment 6 and because this issues is not reproducible I will close this bug.