Closed Bug 1331318 Opened 3 years ago Closed 3 years ago

Add learn more link in the Site Data section

Categories

(Firefox :: Preferences, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 53
Tracking Status
firefox53 --- fixed

People

(Reporter: Fischer, Assigned: Fischer)

References

Details

(Whiteboard: [storage-v1])

Attachments

(1 file)

There should ba a learn more link for the persistent storage in the Site Data section [1]

[1] https://mozilla.invisionapp.com/share/4Y87EJO39#/screens/179637920
Assignee: nobody → fliu
Depends on: 1313602
No longer depends on: 1312372, 1312374
Comment on attachment 8827056 [details]
Bug 1331318 - Add learn more link in the Site Data section

https://reviewboard.mozilla.org/r/104884/#review105590

::: browser/components/preferences/in-content/advanced.xul:335
(Diff revision 1)
>        <groupbox id="siteDataGroup" hidden="true">
>          <caption><label>&siteData.label;</label></caption>
>  
>          <hbox align="center">
> -          <label id="totalSiteDataSize" flex="1"></label>
> +          <label id="totalSiteDataSize"></label>
> +          <label id="siteDataLearnMoreLink" class="learnMore text-link" value="&siteDataLearnMoreLink.label;"></label>

The .learnMore [1] CSS class selector is reused from the bug 1324170.
The bug 1324170 unified the learn more link position in about:preferences.

[1] https://dxr.mozilla.org/mozilla-central/source/browser/themes/shared/incontentprefs/preferences.inc.css#47
Comment on attachment 8827056 [details]
Bug 1331318 - Add learn more link in the Site Data section

Gijs,

This patch adds one learn more link for the persistent storage in the Site Data section [1]

[1] https://mozilla.invisionapp.com/share/4Y87EJO39#/screens/179637920

Thanks
Attachment #8827056 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8827056 [details]
Bug 1331318 - Add learn more link in the Site Data section

https://reviewboard.mozilla.org/r/104886/#review105698
Attachment #8827056 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/66046ad80298
Add learn more link in the Site Data section r=Gijs
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/66046ad80298
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
QA Whiteboard: [good first verify]
You need to log in before you can comment on or make changes to this bug.