1331318 - Add learn more link in the Site Data section

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Fischer [:Fischer]]

There should ba a learn more link for the persistent storage in the Site Data section [1]

[1] https://mozilla.invisionapp.com/share/4Y87EJO39#/screens/179637920

Comment 1

[Fischer [:Fischer]]

Attachment: Bug 1331318 - Add learn more link in the Site Data section

Review commit: https://reviewboard.mozilla.org/r/104886/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/104886/

Comment 2

[Fischer [:Fischer]]

Comment on attachment 8827056 [details]
Bug 1331318 - Add learn more link in the Site Data section

https://reviewboard.mozilla.org/r/104884/#review105590

::: browser/components/preferences/in-content/advanced.xul:335
(Diff revision 1)
>        <groupbox id="siteDataGroup" hidden="true">
>          <caption><label>&siteData.label;</label></caption>
>  
>          <hbox align="center">
> -          <label id="totalSiteDataSize" flex="1"></label>
> +          <label id="totalSiteDataSize"></label>
> +          <label id="siteDataLearnMoreLink" class="learnMore text-link" value="&siteDataLearnMoreLink.label;"></label>

The .learnMore [1] CSS class selector is reused from the bug 1324170.
The bug 1324170 unified the learn more link position in about:preferences.

[1] https://dxr.mozilla.org/mozilla-central/source/browser/themes/shared/incontentprefs/preferences.inc.css#47

Comment 3

[Fischer [:Fischer]]

Comment on attachment 8827056 [details]
Bug 1331318 - Add learn more link in the Site Data section

Gijs,

This patch adds one learn more link for the persistent storage in the Site Data section [1]

[1] https://mozilla.invisionapp.com/share/4Y87EJO39#/screens/179637920

Thanks

Comment 4

[:Gijs (he/him)]

Comment on attachment 8827056 [details]
Bug 1331318 - Add learn more link in the Site Data section

https://reviewboard.mozilla.org/r/104886/#review105698

Comment 5

[Fischer [:Fischer]]

TRY: https://treeherder.mozilla.org/#/jobs?repo=try&revision=67d0219405ac0490734147efee32f46baaadc5db

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/66046ad80298
Add learn more link in the Site Data section r=Gijs

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/66046ad80298