Closed Bug 1331421 Opened 7 years ago Closed 7 years ago

Migrate ShareTo target to Swift 3.0

Categories

(Firefox for iOS :: General, defect, P1)

Other
iOS
defect

Tracking

()

RESOLVED FIXED

People

(Reporter: fluffyemily, Assigned: farhan)

References

Details

(Whiteboard: [MobileCore])

Attachments

(1 file)

55 bytes, text/x-github-pull-request
fluffyemily
: review+
Details | Review
1. Assign bug for the module to yourself. Ensure all dependent modules are already migrated.
2. Create branch for automatic migration. Only migrate chosen module. Commit. There is no need to review automated migration code.
3. Create branch for manual migration. This is to make reviews easier. Only manual  migrations are to be code reviewed.
4. Select scheme for module. This is to enable each module to be fixed for compilation due to no dependencies outside of module that have not been migrated
5. Fix build errors including porting of Alamofire code to Alamofire 4.0. A migration guide is available.
6. Run tests and ensure they work.
Blocks: 1323459
Whiteboard: [MobileCore]
Blocks: 1331424
Priority: -- → P2
Assignee: nobody → etoop
Assignee: etoop → nobody
Attached file Pull Request
here's shareTo. If you think its good. you can merge it in so fewer conflicts to deal with later.
Attachment #8832278 - Flags: review?(etoop)
Assignee: nobody → fpatel
Priority: P2 → P1
Attachment #8832278 - Flags: review?(etoop) → review+
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: