review sidebar-button injection

RESOLVED FIXED in Firefox 54

Status

()

Toolkit
WebExtensions: General
P1
normal
RESOLVED FIXED
7 months ago
4 months ago

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

Tracking

55 Branch
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox54 fixed, firefox55 fixed)

Details

(Whiteboard: sidebar, needs UX, triaged)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

7 months ago
For the new sidebarAction API we inject the sidebar-button into the toolbar, before the back-button.  This is limited to nightly and aurora.

We need to UX review this and consider user testing.

Comment 1

7 months ago
Hi Markus,  We need ux for this part.  Ask Shane (mixedpuppy) for details if not clear.
Flags: needinfo?(mjaritz)
Whiteboard: sidebar, needs UX
Hi Shane, thanks for triggering a review of this.
how can I experience that behavior currently? (First for review, then probably for user testing.)
Is this functionality already in Nightly? If so, where can I find an extension to test it with?
Flags: needinfo?(mjaritz)
(Assignee)

Comment 3

7 months ago
Hi Markus,
Per talking with Kev, I'm going to land the behavior that I've created in bug 1208596.  This bug should get a comment when that lands.  I'll make a simple extension available here as well.

Comment 4

7 months ago
ignore in triage until bug 1208596 has landed and then UX review feedback.
Flags: needinfo?(sescalante)
(Assignee)

Comment 5

7 months ago
I don't think there is any reason to re-triage this, its just something that has to be done.
Flags: needinfo?(sescalante)
Whiteboard: sidebar, needs UX → sidebar, needs UX, triaged

Updated

6 months ago
Blocks: 1344435
(Assignee)

Comment 6

5 months ago
Hi Markus,
We need to deal with this soon since uplift will move this to beta (where it is currently disabled).
Flags: needinfo?(mjaritz)
(Assignee)

Updated

5 months ago
Blocks: 1350664
(Assignee)

Updated

5 months ago
Assignee: nobody → mixedpuppy
Priority: P2 → P1
Version: 49 Branch → 55 Branch
How soon is soon? Francis started work on the user test, he can best give an estimate of when we can have a result of the sidebar user test.
If we not get the user test results in time, I propose we still move forward with the implementation for beta, and only change that if we get a negative result from user testing later.
Flags: needinfo?(mjaritz)
Flags: needinfo?(mixedpuppy)
Flags: needinfo?(fdjabri)
(Assignee)

Comment 8

5 months ago
Fx54 merge is Apr-17.

Our choice is to

a) take it as-is, perhaps with a small change, or 
b) remove it entirely

I only need to uplift a small patch in either case, need to have that mid-week the week before (e.g. Apr 11/12)

If we change the sidebar toolbar button in any significant way it will not make it into 54 and we'll need to do one of the above for 54.
Flags: needinfo?(mixedpuppy)
(Assignee)

Updated

5 months ago
webextensions: --- → ?

Updated

5 months ago
Status: NEW → RESOLVED
Last Resolved: 5 months ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1353421
(Assignee)

Comment 10

5 months ago
This bug will need patches that will be uplifted in order to avoid test failures when 54 hits beta.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Comment hidden (mozreview-request)

Comment 12

4 months ago
mozreview-review
Comment on attachment 8858385 [details]
Bug 1331507 remove release/beta restriction on injecting sidebar button,

https://reviewboard.mozilla.org/r/130328/#review133062
Attachment #8858385 - Flags: review?(kmaglione+bmo) → review+

Comment 13

4 months ago
Pushed by mixedpuppy@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/97a254965abd
remove release/beta restriction on injecting sidebar button, r=kmag
(Assignee)

Comment 14

4 months ago
Comment on attachment 8858385 [details]
Bug 1331507 remove release/beta restriction on injecting sidebar button,

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1350664 beta/release restriction removed
[User impact if declined]:none
[Is this code covered by automated tests?]:yes
[Has the fix been verified in Nightly?]:coming soon.
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]:none
[Is the change risky?]:no
[Why is the change risky/not risky?]:code has been running on nightly/aurora, removing restriction prior to beta uplift
[String changes made/needed]:none

requesting early since this is needed for fx 54 beta.
Attachment #8858385 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/97a254965abd
Status: REOPENED → RESOLVED
Last Resolved: 5 months ago4 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Comment on attachment 8858385 [details]
Bug 1331507 remove release/beta restriction on injecting sidebar button,

prevent bustage on beta after next merge, aurora54+
Attachment #8858385 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 17

4 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/34ba7c94dc4c
status-firefox54: --- → fixed
Duplicate of this bug: 1350664
We finished user tests on this sidebar implementation and it looks like people know how to use it and can identify the button as the way to bring sidebars back up after closing them. Found some improvements we could make, which will be part of Photon.
Flags: needinfo?(fdjabri)
You need to log in before you can comment on or make changes to this bug.