|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
For the new sidebarAction API we inject the sidebar-button into the toolbar, before the back-button. This is limited to nightly and aurora. We need to UX review this and consider user testing.
Hi Markus, We need ux for this part. Ask Shane (mixedpuppy) for details if not clear.
Hi Shane, thanks for triggering a review of this. how can I experience that behavior currently? (First for review, then probably for user testing.) Is this functionality already in Nightly? If so, where can I find an extension to test it with?
Hi Markus, Per talking with Kev, I'm going to land the behavior that I've created in bug 1208596. This bug should get a comment when that lands. I'll make a simple extension available here as well.
ignore in triage until bug 1208596 has landed and then UX review feedback.
I don't think there is any reason to re-triage this, its just something that has to be done.
Hi Markus, We need to deal with this soon since uplift will move this to beta (where it is currently disabled).
How soon is soon? Francis started work on the user test, he can best give an estimate of when we can have a result of the sidebar user test. If we not get the user test results in time, I propose we still move forward with the implementation for beta, and only change that if we get a negative result from user testing later.
Fx54 merge is Apr-17. Our choice is to a) take it as-is, perhaps with a small change, or b) remove it entirely I only need to uplift a small patch in either case, need to have that mid-week the week before (e.g. Apr 11/12) If we change the sidebar toolbar button in any significant way it will not make it into 54 and we'll need to do one of the above for 54.
This bug will need patches that will be uplifted in order to avoid test failures when 54 hits beta.
Comment on attachment 8858385 [details] Bug 1331507 remove release/beta restriction on injecting sidebar button, https://reviewboard.mozilla.org/r/130328/#review133062
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/97a254965abd remove release/beta restriction on injecting sidebar button, r=kmag
Comment on attachment 8858385 [details] Bug 1331507 remove release/beta restriction on injecting sidebar button, Approval Request Comment [Feature/Bug causing the regression]: Bug 1350664 beta/release restriction removed [User impact if declined]:none [Is this code covered by automated tests?]:yes [Has the fix been verified in Nightly?]:coming soon. [Needs manual test from QE? If yes, steps to reproduce]: no [List of other uplifts needed for the feature/fix]:none [Is the change risky?]:no [Why is the change risky/not risky?]:code has been running on nightly/aurora, removing restriction prior to beta uplift [String changes made/needed]:none requesting early since this is needed for fx 54 beta.
Comment on attachment 8858385 [details] Bug 1331507 remove release/beta restriction on injecting sidebar button, prevent bustage on beta after next merge, aurora54+
We finished user tests on this sidebar implementation and it looks like people know how to use it and can identify the button as the way to bring sidebars back up after closing them. Found some improvements we could make, which will be part of Photon.