stylo: Implement glue for flex-basis

RESOLVED FIXED

Status

()

Core
CSS Parsing and Computation
P1
normal
RESOLVED FIXED
5 months ago
3 months ago

People

(Reporter: xidorn, Assigned: canaltinova)

Tracking

(Blocks: 1 bug)

Trunk
Points:
---

Firefox Tracking Flags

(firefox53 affected)

Details

(Reporter)

Description

5 months ago
Testcase:
<!DOCTYPE html>
<p style="flex-basis: 1px"></p>
<script>
alert(getComputedStyle(document.querySelector('p')).flexBasis);
</script>

It should return "1px" but it returns the initial value of flex-basis which is "auto".


It seems this is expected as we haven't implemented glue for flex-basis given comment in gecko.mako.rs [1].

[1] https://github.com/servo/servo/blob/66af7e4d3aeabcdecf08c8ada8cf2ed1b5ba2d64/components/style/properties/gecko.mako.rs#L459
Nazim, do you have cycles to work on this?
Flags: needinfo?(canaltinova)
(Assignee)

Comment 2

4 months ago
Sure, I can work on this!
Flags: needinfo?(canaltinova)
\o/
Assignee: nobody → canaltinova
Priority: -- → P1
(Assignee)

Comment 4

4 months ago
Opened a PR in Servo: https://github.com/servo/servo/pull/15896
Nazim's PR for this landed in Servo. Nice work!
Status: NEW → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.