Closed Bug 1331529 Opened 8 years ago Closed 7 years ago

stylo: Implement glue for flex-basis

Categories

(Core :: CSS Parsing and Computation, defect, P1)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox53 --- affected

People

(Reporter: xidorn, Assigned: canova)

References

Details

Testcase:
<!DOCTYPE html>
<p style="flex-basis: 1px"></p>
<script>
alert(getComputedStyle(document.querySelector('p')).flexBasis);
</script>

It should return "1px" but it returns the initial value of flex-basis which is "auto".


It seems this is expected as we haven't implemented glue for flex-basis given comment in gecko.mako.rs [1].

[1] https://github.com/servo/servo/blob/66af7e4d3aeabcdecf08c8ada8cf2ed1b5ba2d64/components/style/properties/gecko.mako.rs#L459
Nazim, do you have cycles to work on this?
Flags: needinfo?(canaltinova)
Sure, I can work on this!
Flags: needinfo?(canaltinova)
\o/
Assignee: nobody → canaltinova
Priority: -- → P1
Nazim's PR for this landed in Servo. Nice work!
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.